Date: Sun, 29 Sep 2002 06:42:28 -0700 (PDT) From: Bruce Evans <bde@FreeBSD.org> To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/lib/csu/i386-elf crt1.c Message-ID: <200209291342.g8TDgSt6008593@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
bde 2002/09/29 06:42:27 PDT
Modified files:
lib/csu/i386-elf crt1.c
Log:
Align the stack suitably for the version of gcc in FreeBSD-4 (provided
-fomit-frame-pointer is not used). This is mostly moot for -current
because gcc-3 does the alignment (slightly incorrectly) in main().
This patch is intended for easy MFC'ing and should be backed out in
-current soon since it causes compiler warnings and better fixes are
possible in -current. The best fix is to do nothing here and wait for
gcc to do stack alignment right. gcc-3 aligns the stack in main(), but
does it too late for main()'s local variables and too late for anything
called before main(). A misaligned stack is now more than an efficiency
problem, since some SSE instructions in some or all (hardware)
implementations trap on misaligned operands even if alignment checking
is not enabled.
PR: 41528:
Submitted by: NIIMI Satoshi <sa2c@sa2c.net> (original version)
MFC after: 3 days
Revision Changes Path
1.10 +33 -0 src/lib/csu/i386-elf/crt1.c
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200209291342.g8TDgSt6008593>