Date: Sun, 28 Jul 2019 21:44:01 +0000 (UTC) From: Rick Macklem <rmacklem@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r350395 - head/usr.bin/nfsstat Message-ID: <201907282144.x6SLi1B6085123@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: rmacklem Date: Sun Jul 28 21:44:01 2019 New Revision: 350395 URL: https://svnweb.freebsd.org/changeset/base/350395 Log: Fix printing of Server Re-Failed and Server Faults. nfsstat -s prints bogus large numbers for the Server Re-Failed and Server Faults fields. This was introduced by r328588. Although I know nothing about libxo, these lines aren't titles and this patch seems to fix the problem, so I am committing it for rea@ who emailed it to me. It also deleted the trailing ':' from the title lines, since those were not in the pre-r328588 output. If there is a more correct fix, someone conversant with libxo will need to do so. Submitted by: rea MFC after: 2 weeks Modified: head/usr.bin/nfsstat/nfsstat.c Modified: head/usr.bin/nfsstat/nfsstat.c ============================================================================== --- head/usr.bin/nfsstat/nfsstat.c Sun Jul 28 21:37:38 2019 (r350394) +++ head/usr.bin/nfsstat/nfsstat.c Sun Jul 28 21:44:01 2019 (r350395) @@ -460,11 +460,11 @@ intpr(int clientOnly, int serverOnly) xo_close_container("operations"); xo_open_container("server"); - xo_emit("{T:Server Re-Failed:}\n"); - xo_emit("{T:retfailed/%17ju}\n", (uintmax_t)ext_nfsstats.srvrpc_errs); + xo_emit("{T:Server Re-Failed}\n"); + xo_emit("{:retfailed/%16ju}\n", (uintmax_t)ext_nfsstats.srvrpc_errs); - xo_emit("{T:Server Faults:}\n"); - xo_emit("{T:faults/%13ju}\n", (uintmax_t)ext_nfsstats.srv_errs); + xo_emit("{T:Server Faults}\n"); + xo_emit("{:faults/%13ju}\n", (uintmax_t)ext_nfsstats.srv_errs); xo_emit("{T:Server Write Gathering:/%13.13s}\n");
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201907282144.x6SLi1B6085123>