Date: Tue, 20 Feb 2007 16:49:36 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern vfs_syscalls.c Message-ID: <20070220144936.GY39168@deviant.kiev.zoral.com.ua> In-Reply-To: <200702191839.58671.jhb@freebsd.org> References: <200702191056.l1JAuASc059200@repoman.freebsd.org> <200702191839.58671.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--4mUolEm2oNas7DxE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 19, 2007 at 06:39:58PM -0500, John Baldwin wrote: > On Monday 19 February 2007 05:56, Konstantin Belousov wrote: > > kib 2007-02-19 10:56:10 UTC > >=20 > > FreeBSD src repository > >=20 > > Modified files: > > sys/kern vfs_syscalls.c=20 > > Log: > > Remove union_dircheckp hook, it is not needed by new unionfs code any= more. > > As consequence, getdirentries() no longer needs to drop/reacquire > > directory vnode lock, that would allow it to be reclaimed in between. >=20 > I think there is at least one more copy of getdirentries() under sys/comp= at, > possibly multiple. Are you going to fix this in all of them? Could you, please, point out where is it ? My grep told me that I removed all references to the union_dircheckp, and I think that getdirentries() code had to have references to it. My change modified two syscalls: getdirentrie= s() and ogetdirentries(). --4mUolEm2oNas7DxE Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFF2wqAC3+MBN1Mb4gRAjjqAKC7KAwblGHoyvBbEiUQvaVt12vwEQCdF2PG qOuDvK/2qUdxw4+/WiWSP2o= =2Hg8 -----END PGP SIGNATURE----- --4mUolEm2oNas7DxE--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070220144936.GY39168>