Date: Fri, 25 Dec 1998 22:00:24 -0500 (EST) From: Brian Feldman <green@unixhelp.org> To: Bruce Evans <bde@zeta.org.au> Cc: current@FreeBSD.ORG Subject: Re: revoke of fifos Message-ID: <Pine.BSF.4.05.9812252156110.24123-100000@janus.syracuse.net> In-Reply-To: <199812251047.VAA29549@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 25 Dec 1998, Bruce Evans wrote:
> >revoke(2) on VFIFO types is broken now, leading to stranded mbuf's. I suppose
>
> I don't think it has ever worked in BSD.
Nor should it need to since, according to revoke.2:
Access to a file may be revoked only by its owner or the super user. The
revoke() function is currently supported only for block and character
special device files.
>
> >bde is tracking this down, but for now, why don't we return EINVAL in revoke(2)?
>
> I thought it wasn't urgent because I thought that only root could revoke :-(.
Nope. Also, to keep in accordance with the manpage, look at the code in -STABLE,
which actually seems to be correct:
vp = nd.ni_vp;
if (vp->v_type != VCHR && vp->v_type != VBLK) {
error = EINVAL;
goto out;
}
error = VOP_GETATTR(vp, &vattr, p->p_ucred, p);
>
> Bruce
>
Brian Feldman _ __ ___ ___ ___
green@unixhelp.org _ __ ___ | _ ) __| \
http://www.freebsd.org/ _ __ ___ ____ | _ \__ \ |) |
FreeBSD: The Power to Serve! _ __ ___ ____ _____ |___/___/___/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.05.9812252156110.24123-100000>