Date: Tue, 9 Aug 2016 08:59:25 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: Navdeep Parhar <np@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r303763 - in head/sys/cddl: compat/opensolaris/sys contrib/opensolaris/uts/common/fs/zfs contrib/opensolaris/uts/common/fs/zfs/sys Message-ID: <92ce3274-916e-db48-04eb-aecd21c65aeb@FreeBSD.org> In-Reply-To: <1b2fa1c4-d219-7b0c-bea4-94ae325565e0@FreeBSD.org> References: <201608050623.u756N695018889@repo.freebsd.org> <a7fa8897-192e-9915-3bf3-d6aae6e9bfe2@FreeBSD.org> <1b2fa1c4-d219-7b0c-bea4-94ae325565e0@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 09/08/2016 08:10, Andriy Gapon wrote: > On 09/08/2016 02:48, Navdeep Parhar wrote: >> Hello Andriy, >> >> I'm at r303837 and have had two panics today in zfs_rename. I have a >> core for a kernel built with -O0. Let me know if you think it's related >> to this commit and need more information. This is the stack: >> >> (also available at https://people.freebsd.org/~np/rename_panic.txt in >> case the wide lines are hard to read in email). > > Thank you very much for the report. > More details are required for analysis. In frame 11 I would like to see objects > pointed to by all arguments and additionally local variables tdzp, sdzp, zfsvfs > and zilog. Navdeep, thank you for the debugging information (provided out-of-band). The problem seems to be with leaving a variable uninitialized when a cross-device rename is detected and then accessing that variable before checking the error code. Also, thank you for testing a fix. I'll commit it very soon. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?92ce3274-916e-db48-04eb-aecd21c65aeb>