Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 13 Sep 2018 07:07:13 +0000 (UTC)
From:      =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <royger@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r338625 - head/sys/x86/xen
Message-ID:  <201809130707.w8D77DrV022764@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: royger
Date: Thu Sep 13 07:07:13 2018
New Revision: 338625
URL: https://svnweb.freebsd.org/changeset/base/338625

Log:
  xen: fix PV IPI setup
  
  So that it's done when the vcpu_id has been set. For the BSP the
  vcpu_id is set at SUB_INTR, while for the APs it's done in
  init_secondary_tail that's called at SUB_SMP order FIRST.
  
  Reported and tested by:	cperciva
  Approved by:		re (gjb)
  Sponsored by:		Citrix Systems R&D
  Differential revision:	https://reviews.freebsd.org/D17013

Modified:
  head/sys/x86/xen/xen_apic.c

Modified: head/sys/x86/xen/xen_apic.c
==============================================================================
--- head/sys/x86/xen/xen_apic.c	Thu Sep 13 07:05:51 2018	(r338624)
+++ head/sys/x86/xen/xen_apic.c	Thu Sep 13 07:07:13 2018	(r338625)
@@ -592,6 +592,6 @@ xen_setup_cpus(void)
 		apic_ops.ipi_vectored = xen_pv_lapic_ipi_vectored;
 }
 
-/* We need to setup IPIs before APs are started */
-SYSINIT(xen_setup_cpus, SI_SUB_SMP-1, SI_ORDER_FIRST, xen_setup_cpus, NULL);
+/* Switch to using PV IPIs as soon as the vcpu_id is set. */
+SYSINIT(xen_setup_cpus, SI_SUB_SMP, SI_ORDER_SECOND, xen_setup_cpus, NULL);
 #endif /* SMP */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201809130707.w8D77DrV022764>