Date: Sat, 13 Jul 2024 14:04:48 +0200 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Mathieu Arnold <mat@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, Baptiste Daroussin <bapt@freebsd.org>, "arrowd@FreeBSD.org" <arrowd@FreeBSD.org> Subject: Re: git: 06601897e5cd - main - framework: reintroduce the feature enabling code Message-ID: <457bab3436f42fd12d80beb16e067cf0@mail.infomaniak.com> In-Reply-To: <6kivt3yarts23vqyv277vqrw6dhswo4hilbdkspvnaz544mtvc@yiyqgdtnp6y7> References: <202404120754.43C7slbr026326@gitrepo.freebsd.org> <12af8e210220224883a7856115f61be9@mail.infomaniak.com> <6kivt3yarts23vqyv277vqrw6dhswo4hilbdkspvnaz544mtvc@yiyqgdtnp6y7>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 2024-07-13T08:47:47.000+02:00, Mathieu Arnold <mat@freebsd.org> wrote: > On Sat, Jul 13, 2024 at 06:11:04AM GMT, Daniel Engberg wrote: >> Hi, >> >> This changes so LTO option is no longer applied to Rust (cargo) >> ports >> >> BY DEFAULT causing a regresssion, please fix. > > As it has been three months, nobody complained something was broken > so, > > I don't think anything is actually broken. > > LTO as are a few other features like SSP are user facing features, > not a > > porters facing options, it means, it's up to the person doing the > > building to choose wether to enable it or not, it is **not** up to > the > > person porting the software to forcefully enable it. > > -- > > Mathieu Arnold Hi, Likely because this pretty much silently went by because it was posted on Phab and you only CCed bapt. It's been enabled since Jan 2023 (https://cgit.freebsd.org/ports/commit/Mk/Uses/cargo.mk?id=967022fd812cf67dec264ee4e53bd016b69e7a2b) and tested/discussed here https://reviews.freebsd.org/D36736 before being enabled/committed. I noticed it now while updating a Rust (cargo-based) port. Best regards, Daniel [-- Attachment #2 --] <html><body><div>On 2024-07-13T08:47:47.000+02:00, Mathieu Arnold <mat@freebsd.org> wrote:<br></div><div class="ik_mail_quote answerContentMessage"><blockquote class="ws-ng-quote"><pre style="white-space: normal;"><div>On Sat, Jul 13, 2024 at 06:11:04AM GMT, Daniel Engberg wrote:<br></div><blockquote class="ws-ng-quote"><div> Hi,<br></div><div> <br></div><div> This changes so LTO option is no longer applied to Rust (cargo) ports<br></div><div> BY DEFAULT causing a regresssion, please fix.<br></div></blockquote><div> <br></div><div>As it has been three months, nobody complained something was broken so,<br></div><div>I don't think anything is actually broken.<br></div><div><br></div><div>LTO as are a few other features like SSP are user facing features, not a<br></div><div>porters facing options, it means, it's up to the person doing the<br></div><div>building to choose wether to enable it or not, it is **not** up to the<br></div><div>person porting the software to forcefully enable it.<br></div><div><br></div><div>-- <br></div><div>Mathieu Arnold<br></div></pre></blockquote></div><div>Hi,<br></div><div><br></div><div>Likely because this pretty much silently went by because it was posted on Phab and you only CCed bapt. It's been enabled since Jan 2023 (<a href="https://cgit.freebsd.org/ports/commit/Mk/Uses/cargo.mk?id=967022fd812cf67dec264ee4e53bd016b69e7a2b">https://cgit.freebsd.org/ports/commit/Mk/Uses/cargo.mk?id=967022fd812cf67dec264ee4e53bd016b69e7a2b</a>) and tested/discussed here <a href="https://reviews.freebsd.org/D36736">https://reviews.freebsd.org/D36736</a>; before being enabled/committed. I noticed it now while updating a Rust (cargo-based) port.<br></div><div><br></div><div>Best regards,<br></div><div>Daniel<br></div></body></html>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?457bab3436f42fd12d80beb16e067cf0>