Date: Sun, 01 Dec 2013 19:40:22 -0800 From: Sean Bruno <sean_bruno@yahoo.com> To: Max Brazhnikov <makc@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, vg@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r335260 - in head/audio/clementine-player: . files Message-ID: <1385955622.1498.114.camel@powernoodle.corp.yahoo.com> In-Reply-To: <1587696.zcDM98VLUm@mercury.ph.man.ac.uk> References: <201311300354.rAU3sGQD056367@svn.freebsd.org> <1587696.zcDM98VLUm@mercury.ph.man.ac.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-pRQw7Qmo40fkzAHtbSi4 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On Sun, 2013-12-01 at 17:41 +0000, Max Brazhnikov wrote:=20 > Hi Sean, >=20 > On Sat, 30 Nov 2013 03:54:16 +0000Sat Nov 30 03:54:16 2013 Sean Bruno wro= te: > > Author: sbruno (src committer) > > Date: Sat Nov 30 03:54:16 2013 > > New Revision: 335260 > > URL: http://svnweb.freebsd.org/changeset/ports/335260 > >=20 > > Log: > > Update audio/clementine-player to 1.2.0 > > =20 > > This now works on 11-current > > =20 > > PR: ports/178687 >=20 > Was this update approved? >=20 I'm going to go with "no" as vg@ did not review completely nor did he explicitly give approval. The port was completely broken, so I fixed it. =20 > > +WITH_DEBUG=3D yes >=20 > WITH_DEBUG shouldn't be set in Makefiles >=20 Ah, debugging leftover. Will remove. > > INSTALLS_ICONS=3D yes > > USE_GSTREAMER=3D gio ogg mp3 flac soup vorbis > > MAKE_JOBS_UNSAFE=3D yes > > CONFLICTS_BUILD=3D qt-3.* > > =20 > > CMAKE_ARGS+=3D -DCMAKE_LIBRARY_PATH:PATH=3D"${LOCALBASE}/lib:${PREFIX}= /lib" \ > > - -DENABLE_IMOBILEDEVICE=3DOFF > > + -DENABLE_IMOBILEDEVICE=3DOFF -DENABLE_SPARKLE=3DOFF \ > > + -DENABLE_SOUNDMENU=3DOFF -DENABLE_DBUS=3DOFF -DENABLE_UBUNTU_ONE=3DO= FF \ > > + -DENABLE_DROPBOX=3DOFF -DENABLE_SKYDRIVE=3DOFF >=20 > You have globally disabled DBus support here, which looks wrong, consider= ing > that you have added DBUS options. There's more issues with dbus in this p= ort, > see below. > =20 More debugging leftover. I'll remove this. > > + > > +.if ${PORT_OPTIONS:MUSE_BUILTIN_TAGLIB} > > +CMAKE_ARGS+=3D -DENABLE_USE_BUILTIN_TAGLIB=3DON > > +.else > > +CMAKE_ARGS+=3D -DENABLE_USE_BUILTIN_TAGLIB=3DOFF > > +.endif >=20 > What's the reason for this option? We usually try to avoid build-in > dependencies. >=20 The builtin taglib is much smaller, and less feature rich compared to using the external audio/taglib. So, its a feature of the application and it seems to work. I've set it to off by default, and I don't see the harm in letting users configure it. > > .if ${PORT_OPTIONS:MWIIMOTEDEV} > > -CMAKE_ARGS+=3D -DENABLE_WIIMOTEDEV=3DON > > +CMAKE_ARGS+=3D -DENABLE_WIIMOTEDEV=3DON \ > > + -DENABLE_DBUS=3DON >=20 > You'll end up with both -DENABLE_DBUS=3DON and -DENABLE_DBUS=3DOFF, if yo= u try > to build the port with WIIMOTEDEV, but without DBUS option. You either ha= ve > to fiddle with options to avoid this, or remove DBUS option for simplicit= y. > As far as I remember WIIMOTEDEV is not the only option that requires dbus > support, please check it if you want to keep DBUS option. >=20 Agreed. This is a misconfiguration. Cmake was hiding this from me by doing the right thing. > > Modified: head/audio/clementine-player/pkg-plist > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/audio/clementine-player/pkg-plist Sat Nov 30 02:27:05 2013 (r3= 35259) > > +++ head/audio/clementine-player/pkg-plist Sat Nov 30 03:54:16 2013 (r3= 35260) >=20 > <skip> >=20 > > +share/clementine/projectm-presets/Rovastar - Inner Thoughts (Clouded J= udgement Mix).milk > > +share/clementine/projectm-presets/Che - Burning Hus.milk > > +@dirrmtry share/applications >=20 > share/applications is a part of mtree now, it shouldn't be in plist. >=20 > Regards, > Max >=20 >=20 Fixed. Thanks. I suspect that I should actually go through the process of getting a port commit "bit" for stuff. Especially if I'm going to be playing around in here. :-) sean --=-pRQw7Qmo40fkzAHtbSi4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iQEcBAABAgAGBQJSnAEiAAoJEBkJRdwI6BaHeJcH/RzM4RkRCqFRmhH9oH1ks3EL p5R9b1z3s23axjAMLtxwlmKBd8/N1nq/Rl1KgV5ybvqhUOM2eE78KB4BSeA76Cn3 XQ91gKWlaWQxlWqdkSbECuAd4MQYLsgfKJc5j9nFrvu4umFwzzK9mEslnLqJ8if2 V5pYZ29uaUuCJDKy0ujwWiQIF3j7Ef7EmfhtMAAWu1oMT+1X284nq3cx3W0AjuRq wezbwWhJjzI6YeZ21xH9xuCdsnMEB42OXc/yoANc9g07BYgsrAg81o5fhnNiu+Sj /mvK6rITw3KQryZjRLbq5vdiWTWzwtBV9j9vR/5h01stPcOk4SCRBNGC7/+nEw4= =t7sr -----END PGP SIGNATURE----- --=-pRQw7Qmo40fkzAHtbSi4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1385955622.1498.114.camel>