Date: Mon, 8 Nov 2010 15:18:05 GMT From: Eitan Adler <lists@eitanadler.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/152053: [patch] portlint shouldn't report that 'work' isn't in cvs Message-ID: <201011081518.oA8FI5ak085320@www.freebsd.org> Resent-Message-ID: <201011081520.oA8FK98D053594@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 152053 >Category: ports >Synopsis: [patch] portlint shouldn't report that 'work' isn't in cvs >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Nov 08 15:20:09 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Eitan Adler >Release: >Organization: >Environment: >Description: portlint currently reports two conflicting messages when it finds a "work" directory in a port a) Make sure it isn't committed b) It was not found in CVS >How-To-Repeat: >Fix: This patch silences the second one --- portlint.old 2010-11-05 14:02:28.000000000 -0400 +++ portlint 2010-11-07 20:58:57.000000000 -0500 @@ -464,7 +464,7 @@ if /^(?:\.\.?|CVS)$/; my $filename = $dir eq '.' ? $_ : "$dir/$_"; if (-d $filename) { - if (!$entries{$_} || $entries{$_} ne 'D') { + if ((!$entries{$_} || $entries{$_} ne 'D') && $filename ne 'work') { &perror("FATAL", "", -1, "directory $filename not in CVS."); } else { >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201011081518.oA8FI5ak085320>