Date: Mon, 16 Jul 2018 10:57:52 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: Gerald Pfeifer <gerald@pfeifer.com>, Dmitry Marakasov <amdmi3@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r470444 - head/lang/gcc-ecj45 Message-ID: <20180716105752.GA69746@FreeBSD.org> In-Reply-To: <20180716094530.k6ls4yddh2nmlivd@ogg.in.absolight.net> References: <201805200904.w4K94BAh007929@repo.freebsd.org> <alpine.LSU.2.21.1807142237341.5444@anthias.pfeifer.com> <20180716094530.k6ls4yddh2nmlivd@ogg.in.absolight.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jul 16, 2018 at 11:45:30AM +0200, Mathieu Arnold wrote: > On Sat, Jul 14, 2018 at 10:39:11PM +0200, Gerald Pfeifer wrote: > > I'm not really sure "cosmetic fixes" are covered by portmgr > > blanket, especially where something is a style issue. > > > > > -EXTRACT_SUFX= > > > -EXTRACT_ONLY= > > > +EXTRACT_SUFX= # empty > > > +EXTRACT_ONLY= # empty > > > > ...I preferred the original version of that and do not see this > > as a real improvement. > > There is some kind of, mmmm, style police that, I think, believe > variables must have a value No, it's not about that variables must have a value, it's to designate that it was made empty on purpose, it's not a stray line or some editor glitch. Kind of like why people write "while (...) continue;" rather than simply "while (...);". The former clearly shows the intentions, the latter could be just a stupid bug. > Never understood it myself. Hope now it is more clear for you. :-) ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180716105752.GA69746>