Date: Wed, 19 Jan 2011 16:56:35 +1100 From: Peter Jeremy <peterjeremy@acm.org> To: John Baldwin <jhb@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r217538 - in head/sys/dev: buslogic cs Message-ID: <20110119055635.GA90983@server.vk2pj.dyndns.org> In-Reply-To: <201101181523.p0IFNGeB042079@svn.freebsd.org> References: <201101181523.p0IFNGeB042079@svn.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
On 2011-Jan-18 15:23:16 +0000, John Baldwin <jhb@FreeBSD.org> wrote:
>Log:
> Remove some always-true comparisons.
...
>--- head/sys/dev/cs/if_cs.c Tue Jan 18 14:58:44 2011 (r217537)
>+++ head/sys/dev/cs/if_cs.c Tue Jan 18 15:23:16 2011 (r217538)
>@@ -364,7 +364,7 @@ cs_cs89x0_probe(device_t dev)
>
> if (!error && !(sc->flags & CS_NO_IRQ)) {
> if (chip_type == CS8900) {
>- if (irq >= 0 || irq < 16)
>+ if (irq < 16)
> irq = cs8900_irq2eeint[irq];
> else
> irq = 255;
Irrespective of the signedness or otherwise of "irq", I'm fairly
certain that '||' should have been '&&' before.
--
Peter Jeremy
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (FreeBSD)
iEYEARECAAYFAk02fRMACgkQ/opHv/APuIcsmQCggV/6tmuYKpkcgsSM9/XGvRwh
HfEAnA1Zxh0rptCg9lEITD24IJDSnrFx
=HmtV
-----END PGP SIGNATURE-----
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110119055635.GA90983>