Date: Wed, 15 Feb 2017 12:31:45 +0000 From: Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com> To: liuyingdong <liuyingdong@huawei.com> Cc: <freebsd-xen@freebsd.org>, <suoben@huawei.com>, <zhao.zhaojun@huawei.com>, <wanglinkai@huawei.com>, <leo.gaoxiaodong@huawei.com>, <chuzhaosong@huawei.com>, <chunfeng.wang@huawei.com> Subject: Re: Multiple patch review =?utf-8?Q?=28was?= =?utf-8?B?OiBSZTog562U5aSNOiDnrZTlpI06IFtQQVRDSF1uZXRmcm9udDogbmVlZCBy?= =?utf-8?Q?eleas?= =?utf-8?Q?e?= all resources) after adding and removing NICs time and again Message-ID: <20170215123145.ucobkwzft6jrgcsu@dhcp-3-221.uk.xensource.com> In-Reply-To: <af1ffb76-b9c4-8397-5f41-a9759b11d932@huawei.com> References: <1676c942-84ec-e573-42e9-8debd47aeb1b@huawei.com> <af1ffb76-b9c4-8397-5f41-a9759b11d932@huawei.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Feb 15, 2017 at 02:06:36PM +0200, liuyingdong wrote: > On 2017/2/13 12:05, liuyingdong wrote: > > å‘件人: roger.pau@citrix.com [mailto:roger.pau@citrix.com] > > å‘é€æ—¶é—´: 2017å¹´2月10æ—¥ 17:12 > > 收件人: Liuyingdong <liuyingdong@huawei.com> > > 抄é€: freebsd-xen@freebsd.org; Suoben <suoben@huawei.com>; Zhaojun (Euler) <zhao.zhaojun@huawei.com>; Wanglinkai <wanglinkai@huawei.com>; chuzhaosong <chuzhaosong@huawei.com>; Wangchunfeng (Ivan) <chunfeng.wang@huawei.com>; Gaoxiaodong (Leo) <leo.gaoxiaodong@huawei.com> > > 主题: Multiple patch review (was: Re: ç”å¤: ç”å¤: [PATCH]netfront: need release all resources) after adding and removing NICs time and again > > > > On Tue, Feb 07, 2017 at 04:55:34PM +0000, Liuyingdong wrote: > >> Hi Roger, > >> I am so sorry and please review tne below URL: > >> https://lists.freebsd.org/pipermail/freebsd-xen/2017-February/002957.h > >> tml > > > > Hello, > > > > Thanks for the patches, and sorry for the delay. It seems like you have not applied some of my comments, so I will have to re-post them here. If some of the comments don't apply for whatever reason, please reply back and explain why, or else this is not going to progress in an useful way for any of us. > > > > I would also request you to look into using `git send-email`, reviewing your patches as attachments is not very comfortable. Or else, you could create an account to https://reviews.freebsd.org/ and upload the patches there assigning me as a reviewer. > > > I have created an account to https://reviews.freebsd.org/ and uploaded the patches but I cann't assign you as a reviewer so I assign visible to All Users. > The three modified patches are as follows: > 1.https://reviews.freebsd.org/differential/diff/25207/ > 2.https://reviews.freebsd.org/differential/diff/25208/ > 3.https://reviews.freebsd.org/differential/diff/25209/ You need to finish creating the revision, click on "Continue", and add a title/description and reviewers, see https://wiki.freebsd.org/Phabricator#Create_a_Revision_via_Web_Interface for more information. Roger.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170215123145.ucobkwzft6jrgcsu>