Date: Fri, 04 Aug 2023 16:09:27 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 229719] src/lib/libpam/modules/pam_krb5/pam_krb5.c:536]: (style) Suspicious condition Message-ID: <bug-229719-227-pxx2Z7ORGv@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-229719-227@https.bugs.freebsd.org/bugzilla/> References: <bug-229719-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D229719 --- Comment #1 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dacc7cf8641dcedad295ff0e569c3f3a28= 939ada0 commit acc7cf8641dcedad295ff0e569c3f3a28939ada0 Author: Dag-Erling Sm=C3=B8rgrav <des@FreeBSD.org> AuthorDate: 2023-08-04 16:08:21 +0000 Commit: Dag-Erling Sm=C3=B8rgrav <des@FreeBSD.org> CommitDate: 2023-08-04 16:08:37 +0000 pam_krb5: Clarify a loop condition. The closing parenthesis was in the wrong location, so instead of assign= ing the return value to krbret and then comparing it to zero, we were assigning= the result of the comparison to krbret and then comparing that to zero. This h= as no practical significance since the value is not used after the loop terminates. PR: 229719 Reviewed by: cy Differential Revision: https://reviews.freebsd.org/D41299 lib/libpam/modules/pam_krb5/pam_krb5.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-229719-227-pxx2Z7ORGv>