Date: Fri, 18 Jan 2008 08:53:12 -0500 From: John Baldwin <jhb@freebsd.org> To: freebsd-stable@freebsd.org Cc: Peter Jeremy <peterjeremy@optushome.com.au> Subject: Re: kldstat causes kernel to print odd message Message-ID: <200801180853.13207.jhb@freebsd.org> In-Reply-To: <20080118055754.GV929@server.vk2pj.dyndns.org> References: <200801171410.38488.doconnor@gsoft.com.au> <200801180817.49452.doconnor@gsoft.com.au> <20080118055754.GV929@server.vk2pj.dyndns.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 18 January 2008 12:57:54 am Peter Jeremy wrote: > On Fri, Jan 18, 2008 at 08:17:40AM +1030, Daniel O'Connor wrote: > >On Fri, 18 Jan 2008, John Baldwin wrote: > >> amd64 uses link_elf_obj.c, all the other archs use link_elf.c, hence > >> the duplication. > > Then why does amd64 need link_elf.c at all? I don't think it does, but it's currently marked standard in sys/conf/files so it is probably laziness (i.e. moving it to all the sys/conf/files.<arch> for non-amd64) that keeps it in there. > >I guess one option would be to put #ifdef amd64 around the error message > >in link_elf.c. > > If there's a possibility that multiple ELF linkers could be required in > the future, a cleaner option might be to make link_elf_error() just cache > the error message and only report it after all possible linkers have > refused to load the file. I think this is the better idea. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200801180853.13207.jhb>