Date: Tue, 17 Feb 2026 00:29:04 +0000 From: Alan Somers <asomers@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: dc9a8d300ba5 - main - aio(4) tests: do not rely on (int *)-1 being invalid address Message-ID: <6993b650.36266.1439c545@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch main has been updated by asomers: URL: https://cgit.FreeBSD.org/src/commit/?id=dc9a8d300ba5c4c319589d78231e9d0e76576cbf commit dc9a8d300ba5c4c319589d78231e9d0e76576cbf Author: Alan Somers <asomers@FreeBSD.org> AuthorDate: 2026-02-17 00:27:02 +0000 Commit: Alan Somers <asomers@FreeBSD.org> CommitDate: 2026-02-17 00:27:38 +0000 aio(4) tests: do not rely on (int *)-1 being invalid address Explicitly mmap guard and use it as the invalid address instead. MFC after: 1 week --- tests/sys/aio/aio_test.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/sys/aio/aio_test.c b/tests/sys/aio/aio_test.c index def8a9d548d6..3f07d9df9810 100644 --- a/tests/sys/aio/aio_test.c +++ b/tests/sys/aio/aio_test.c @@ -39,6 +39,7 @@ #include <sys/param.h> #include <sys/event.h> +#include <sys/mman.h> #include <sys/mdioctl.h> #include <sys/module.h> #include <sys/resource.h> @@ -1665,6 +1666,7 @@ ATF_TC_BODY(aio_writev_efault, tc) struct aiocb aio; ssize_t buflen; char *buffer; + void *unmapped; struct iovec iov[2]; long seed; int fd; @@ -1673,13 +1675,16 @@ ATF_TC_BODY(aio_writev_efault, tc) fd = aio_md_setup(); + unmapped = mmap(NULL, PAGE_SIZE, PROT_NONE, MAP_GUARD, -1, 0); + ATF_REQUIRE(unmapped != MAP_FAILED); + seed = random(); buflen = 4096; buffer = malloc(buflen); aio_fill_buffer(buffer, buflen, seed); iov[0].iov_base = buffer; iov[0].iov_len = buflen; - iov[1].iov_base = (void*)-1; /* Invalid! */ + iov[1].iov_base = (void*)unmapped; /* Invalid! */ iov[1].iov_len = buflen; bzero(&aio, sizeof(aio)); aio.aio_fildes = fd;home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6993b650.36266.1439c545>