Date: Wed, 3 Jul 2013 12:33:36 +0200 From: Davide Italiano <davide@freebsd.org> To: =?ISO-8859-1?Q?Ulrich_Sp=F6rlein?= <uqs@freebsd.org>, Davide Italiano <davide@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r252356 - in head: contrib/smbfs/mount_smbfs etc/defaults etc/mtree include lib lib/libprocstat rescue/rescue sbin/mount share/examples share/examples/etc share/mk sys/conf sys/kern sys... Message-ID: <CACYV=-HNvPpq5_jJjU9xge=%2B%2Bea_vqPbeRUJ4H7RDF=mnPxM0w@mail.gmail.com> In-Reply-To: <20130703092807.GB2294@acme.spoerlein.net> References: <201306282100.r5SL08kx093999@svn.freebsd.org> <20130703092807.GB2294@acme.spoerlein.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 3, 2013 at 11:28 AM, Ulrich Sp=F6rlein <uqs@freebsd.org> wrote: > On Fri, 2013-06-28 at 21:00:08 +0000, Davide Italiano wrote: >> Author: davide >> Date: Fri Jun 28 21:00:08 2013 >> New Revision: 252356 >> URL: http://svnweb.freebsd.org/changeset/base/252356 >> >> Log: >> - Trim an unused and bogus Makefile for mount_smbfs. >> - Reconnect with some minor modifications, in particular now selsocket= () >> internals are adapted to use sbintime units after recent'ish calloutng >> switch. > > yay, for reconnecting this to the build. Now Coverity Scan is "seeing" > this code and there are dozens of double frees in the form: > > smb_rq_done(rqp); > free(rqp, M_SMBFSDATA); > > But smb_rq_done() is already calling free(rqp). This seems easy to audit > and fix. > (sometimes the order is swapped, so it's a USE_AFTER_FREE instead) > > This is CIDs 1042109 -- 1042126, all in smbfs_smb.c. > > Thanks for looking into this > Uli I've just committed a fix. If there's something I missed don't hesitate to poke me privately. Thanks, --=20 Davide "There are no solved problems; there are only problems that are more or less solved" -- Henri Poincare
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACYV=-HNvPpq5_jJjU9xge=%2B%2Bea_vqPbeRUJ4H7RDF=mnPxM0w>