Date: Tue, 04 Apr 2023 10:15:07 +0000 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 643336549081 - main - If copy_file_range(2) fails with EXDEV, use fall-back. Message-ID: <202304041015.334AF7oF006042@critter.freebsd.dk> In-Reply-To: <ZCv1wFHCOvMEBiJG@FreeBSD.org> References: <202304040740.3347eiU8033699@gitrepo.freebsd.org> <ZCvxNeB0A0hDWa8j@FreeBSD.org> <202304040959.3349xqqB005509@critter.freebsd.dk> <ZCv1wFHCOvMEBiJG@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-------- Alexey Dokuchaev writes: > Okay, but did it leave an empty file, I wonder? I didn't check, but it probably would, because cp(1) must have opened and created the destination in order to call copy_file_range(2). PS: I'll note that EXDEV is not a documented return value from copy_file_range(2), and my surprise that cp(1) did not revert to the fall-back, no matter why copy_file_range(2) failed. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202304041015.334AF7oF006042>