Date: Fri, 31 Oct 2014 10:59:57 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Tijl Coosemans <tijl@FreeBSD.org> Cc: x11@FreeBSD.org, dumbbell@FreeBSD.org Subject: Re: [rfc] Radeon AGP support patches Message-ID: <20141031085956.GN53947@kib.kiev.ua> In-Reply-To: <20141030153130.4d8c441b@kalimero.tijl.coosemans.org> References: <20141026162442.1330d4c3@kalimero.tijl.coosemans.org> <20141027141631.GX1877@kib.kiev.ua> <20141027170055.10af15e6@kalimero.tijl.coosemans.org> <20141027162753.GB1877@kib.kiev.ua> <20141027221058.23a188d0@kalimero.tijl.coosemans.org> <20141029170329.GI53947@kib.kiev.ua> <20141030153130.4d8c441b@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 30, 2014 at 03:31:30PM +0100, Tijl Coosemans wrote: > Thanks. Just to be sure, did you review 2 & 4 as well? Reasoning for the patch 2 seems to be correct. You mean the code from drm_bufs.c:drm_addmap(), I suppose ? My reaction to the patch is the question about maintanability of this approach, for future imports. If all usage of map->handle must be reviewed for correctness, we should switch to the Linux approach of making the handle useable for offset calculation. I suspect that it is used not only by drm1, but I do not know radeon driver. I think that the patch 4 is fine.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141031085956.GN53947>