Date: Tue, 03 Sep 2019 14:07:29 -0000 From: Mariusz Zaborski <oshogbo@freebsd.org> To: Adrian Chadd <adrian@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r346322 - head/lib/libcasper/services/cap_fileargs Message-ID: <20190419120625.GA2747@jarvis> In-Reply-To: <201904171658.x3HGwckd080598@repo.freebsd.org> References: <201904171658.x3HGwckd080598@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--7AUc2qLy4jB3hD7Z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 17, 2019 at 04:58:38PM +0000, Adrian Chadd wrote: > Author: adrian > Date: Wed Apr 17 16:58:38 2019 > New Revision: 346322 > URL: https://svnweb.freebsd.org/changeset/base/346322 >=20 > Log: > [casper] fix compilation when casper is disabled. > =20 > This triggers an error in gcc-mips 6.4.0 complaining about unused argum= ents. > =20 > Tested: > =20 > * compiled/run on mips32; nothing complained. >=20 > Modified: > head/lib/libcasper/services/cap_fileargs/cap_fileargs.h >=20 > Modified: head/lib/libcasper/services/cap_fileargs/cap_fileargs.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/lib/libcasper/services/cap_fileargs/cap_fileargs.h Wed Apr 17 16= :45:42 2019 (r346321) > +++ head/lib/libcasper/services/cap_fileargs/cap_fileargs.h Wed Apr 17 16= :58:38 2019 (r346322) > @@ -108,8 +108,12 @@ fileargs_cinitnv(cap_channel_t *cas __unused, nvlist= _t > lstat(name, sb) > #define fileargs_open(fa, name) \ > open(name, fa->fa_flags, fa->fa_mode) > -#define fileargs_fopen(fa, name, mode) \ > - fopen(name, mode) > +static inline > +FILE *fileargs_fopen(fileargs_t *fa, const char *name, const char *mode) > +{ > + (void) fa; __unused is not good enough? > + return (fopen(name, mode)); > +} > #define fileargs_free(fa) (free(fa)) > #endif > =20 >=20 --=20 Mariusz Zaborski oshogbo//vx | http://oshogbo.vexillium.org FreeBSD committer | https://freebsd.org Software developer | http://wheelsystems.com If it's not broken, let's fix it till it is!!1 --7AUc2qLy4jB3hD7Z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkD1x0xkJXVVY1Gwf38KEGuLGxWQFAly5ub4ACgkQ38KEGuLG xWSAyxAAoDpfjabhuC7jWIoSj9d7qswZRdwG29tXSMQmpR5XXeNnIqH/5Avgji5m 6AFtksNmD6nquVw/hFQmPZ5Lx0//8LSc4iBOuSadunIiTrR2MwSsr7SQ3PTD077q o+j4OHNnMqJpiwht6FvoC5iXx9sqsI52eoAo5MAq/1FhiAPkzm4VxHyxehZHM6Rq X8SbxG0KClFOh0umt/WF0RZN8aMAnMdqK+wQEkgbgqa6PNQ7sI4NAnDem0+pwNL/ SsD/2h4JXP+g6IuHEJUYXRkZ3vobc5ovd/su+IzqBywSjQ3wraGwiEq75NKIMrDh doi9NRdyKHKdKXI/m2CJ2AtVpMCpnSJ+b0McpsIJ8l04ElNMxXj8Uw5vlUK9cTR1 0B0E5Z4/15GPSwcD1/CzpIXP1oH3GkXj9wyJuYv8D94r5Xpw04M6ECKydEvUHfVS j7Z0mA7IxaLC5+wYVm8SSfcSyj48x6JLRMGfDrnFfyEzrE0Qy+hUvV9eJEedc5xn kD651vNchdisLu9INXlhqke5RIlVvea+083JERVsUDkLDcCFoURqk93wyGIMBUNs mIm/4SaDSgh5p0BNqUw/BM+R4AxLqCyfUFlAaJbJa5jPjhQduGKD2LdZEtBGtrRA RtTUu0iWDCF3tkyWIjmo+S2H+34kP5fRQv2E5rna449v0louZdY= =dVXk -----END PGP SIGNATURE----- --7AUc2qLy4jB3hD7Z--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190419120625.GA2747>