Date: Wed, 19 Feb 2003 01:01:24 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: sibagaki@lsi.melco.co.jp Cc: shiba@freebsd.org, src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/pccard pccarddevs Message-ID: <20030219.010124.23410261.imp@bsdimp.com> In-Reply-To: <20030219162137F.sibagaki@lsi.melco.co.jp> References: <200302151357.h1FDvru9021460@repoman.freebsd.org> <20030215.193910.121221310.imp@bsdimp.com> <20030219162137F.sibagaki@lsi.melco.co.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20030219162137F.sibagaki@lsi.melco.co.jp>
Takeshi Shibagaki <sibagaki@lsi.melco.co.jp> writes:
: I think so, but I'm sad a little when the card is recognized as XI300
: Wireless but the card is YIS YWL-11B actually.
ok.
: In NetBSD, the card is indicated YIS Corp. YWL-11b because pccard
: driver outputs CISTPL_VER1 strings. So it may be better to rewrite
: like NetBSD in FreeBSD.
I like this idea in general, but dispair that a few cards have really
bad CIS. Maybe the right thing to do is to default the descrition to
the CISTPL_VER1 strings, if available. The driver is free to override
the description. Most drivers could simplify a little and rely on the
CIS string to be a good descrition, while those that know the
descrition is lacking could add their own.
To be clear, you'd like to see a change like the following (my cisco
350 card serves as an example):
OLD:
an0: <Aironet 350 Wireless LAN Adapter> at port 0x100-0x13f irq 10 function 0 config 5 on pccard1
NEW:
an0: <Cisco Systems 350 Series Wireless LAN Adapter> at port 0x100-0x13f irq 10 function 0 config 5 on pccard1
"Aironet 350 Wireless LAN Adapter" comes from the if_an_pccard driver,
while "Cisco Systems 350 Series Wireless LAN Adapter" comes from the
cis node talked about above.
Warner
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-src" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030219.010124.23410261.imp>