Date: Wed, 09 Jan 2002 16:50:28 +0900 (JST) From: NINOMIYA Hideyuki <nin@shikoku.ne.jp> To: dillon@apollo.backplane.com Cc: steve@Watt.COM, stable@FreeBSD.ORG, re@FreeBSD.ORG Subject: Re: VXLOCK interlock avoided messages Message-ID: <20020109.165028.74743563.nin@smtp.shikoku.ne.jp> In-Reply-To: <200201082122.g08LMTp61466@apollo.backplane.com> References: <200201082110.g08LAqJ97852@wattres.Watt.COM> <200201082122.g08LMTp61466@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
Matthew Dillon <dillon@apollo.backplane.com> wrote:
Date: Tue, 8 Jan 2002 13:22:29 -0800 (PST)
Subject: Re: VXLOCK interlock avoided messages
Message-Id: <200201082122.g08LMTp61466@apollo.backplane.com>
> We changed this warning into a log() message, but perhaps we should
> simply remove it entirely.
> It's a bogus warning. If the RE's agree I would like to simply remove
> the associated log() calls.
I thought that the following modification would be good.
Index: vfs_subr.c
===================================================================
RCS file: /ext/freebsd_cvs/src/sys/kern/vfs_subr.c,v
retrieving revision 1.249.2.22
diff -u -r1.249.2.22 vfs_subr.c
--- vfs_subr.c 25 Dec 2001 01:27:55 -0000 1.249.2.22
+++ vfs_subr.c 9 Jan 2002 02:29:24 -0000
@@ -1491,7 +1491,9 @@
}
if (vp->v_flag & VXLOCK) {
if (vp->v_vxproc == curproc) {
+#ifdef DEBUG_LOCKS
log(LOG_INFO, "VXLOCK interlock avoided\n");
+#endif
} else {
vp->v_flag |= VXWANT;
simple_unlock(&vp->v_interlock);
Index: vfs_vnops.c
===================================================================
RCS file: /ext/freebsd_cvs/src/sys/kern/vfs_vnops.c,v
retrieving revision 1.87.2.10
diff -u -r1.87.2.10 vfs_vnops.c
--- vfs_vnops.c 25 Dec 2001 01:44:44 -0000 1.87.2.10
+++ vfs_vnops.c 9 Jan 2002 02:29:27 -0000
@@ -661,9 +661,9 @@
tsleep((caddr_t)vp, PINOD, "vn_lock", 0);
error = ENOENT;
} else {
+#ifdef DEBUG_LOCKS
if (vp->v_vxproc != NULL)
log(LOG_INFO, "VXLOCK interlock avoided in vn_lock\n");
-#ifdef DEBUG_LOCKS
vp->filename = filename;
vp->line = line;
#endif
===================================================================
# This message may be beneficial for debug ... :-)
How do all of you think?
----
***************************************************************
* This message is a thing by output of automatic translation. *
* Therefore it will be for there to be a lot of funny parts. *
* Please approve it. *
***************************************************************
NINOMIYA(family name) Hideyuki(fast name) @ ehime japan
mailto:nin@shikoku.ne.jp mailto:nin@Jp.FreeBSD.org
PGP-Fingerprint:6C59 EC08 5B23 6490 44D0 7CD3 DA40 219F 7114 8553
PGP-Public-Key: http://user.shikoku.ne.jp/~nin/pgp/public-key.txt
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020109.165028.74743563.nin>