Date: Mon, 18 Oct 2004 23:21:55 +0300 From: Ruslan Ermilov <ru@FreeBSD.ORG> To: "David O'Brien" <obrien@FreeBSD.ORG> Cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S Message-ID: <20041018202155.GD34236@ip.net.ua> In-Reply-To: <20041018195458.GA2457@dragon.nuxi.com> References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> <20041018173516.GB89681@ip.net.ua> <20041018174511.GA6079@dragon.nuxi.com> <20041018180319.GD89681@ip.net.ua> <20041018190044.GA89411@hub.freebsd.org> <20041018192417.GE89681@ip.net.ua> <20041018195458.GA2457@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--eqp4TxRxnD4KrmFZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, Oct 18, 2004 at 12:54:58PM -0700, David O'Brien wrote:
> On Mon, Oct 18, 2004 at 10:24:17PM +0300, Ruslan Ermilov wrote:
> > On Mon, Oct 18, 2004 at 07:00:47PM +0000, David O'Brien wrote:
> > > On Mon, Oct 18, 2004 at 09:03:20PM +0300, Ruslan Ermilov wrote:
> > > > On Mon, Oct 18, 2004 at 10:45:11AM -0700, David O'Brien wrote:
> > > > > On Mon, Oct 18, 2004 at 08:35:16PM +0300, Ruslan Ermilov wrote:
> > > > > > On Mon, Oct 18, 2004 at 05:19:36PM +0000, David E. O'Brien wrot=
e:
> > > > > > > obrien 2004-10-18 17:19:36 UTC
> > > > > > > FreeBSD src repository
> > > > > > > Modified files:
> > > > > > > lib/libc/i386/net htonl.S ntohl.S=20
> > > > > > > Log:
> > > > > > > Sync with sys/i386/include/endian.h: use the single instruc=
tion 'bswap'.
> ..
> > > Taking=20
> > > Revision Changes Path
> > > 1.10 +4 -0 src/lib/libc/i386/net/htonl.S
> > > 1.10 +4 -0 src/lib/libc/i386/net/ntohl.S
> > >=20
> > > specifically what patch do you suggest that we used in cases like this
> > > rather than #ifdef I386_CPU". And how to use it? That is one in whi=
ch
> > > someone checks out the source and wants to build a userland that is
> > > usable on an I386 machine.
> >=20
> > I thought I already made it clear, seems not.
>=20
> Not clear enough that I was 100% sure how to make you happy.
>=20
Not me, but our i386 users. ;)
> I386_CPU
> needs to be userland land global so we establish the a normal way of
> doing this. What do you think of this patch?
>=20
> Index: /usr/src/share/mk/bsd.cpu.mk
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /home/ncvs/src/share/mk/bsd.cpu.mk,v
> retrieving revision 1.44
> diff -u -r1.44 bsd.cpu.mk
> --- /usr/src/share/mk/bsd.cpu.mk 17 Oct 2004 05:19:45 -0000 1.44
> +++ /usr/src/share/mk/bsd.cpu.mk 18 Oct 2004 19:51:17 -0000
> @@ -100,6 +100,9 @@
> . else
> _ICC_CPUCFLAGS =3D
> . endif # ICC on 'i386'
> +. if ${CPUTYPE} =3D=3D "i386"
> +CFLAGS +=3D -DI386_CPU
> +. endif
> . elif ${MACHINE_ARCH} =3D=3D "alpha"
> _CPUCFLAGS =3D -mcpu=3D${CPUTYPE}
> . elif ${MACHINE_ARCH} =3D=3D "amd64"
>=20
That's what I suggested except that you put it directly to CFLAGS.
I agree that putting it directly to CFLAGS is more correct. Yes,
I like this patch.
Cheers,
--=20
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer
--eqp4TxRxnD4KrmFZ
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)
iD8DBQFBdCXjqRfpzJluFF4RAtREAJ9DJsTPb90brlns8EB5JfeftDxEfACff1sI
6c4DFYBlPs7aCQPwrbJ3G8A=
=sq26
-----END PGP SIGNATURE-----
--eqp4TxRxnD4KrmFZ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041018202155.GD34236>