Date: Tue, 2 Aug 2016 14:17:39 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: "Pedro F. Giffuni" <pfg@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Mikhail Teterin <mi@FreeBSD.org> Subject: Re: svn commit: r303047 - head/usr.bin/sed Message-ID: <20160802141738.GA84154@FreeBSD.org> In-Reply-To: <201607192256.u6JMuewv007503@repo.freebsd.org> References: <201607192256.u6JMuewv007503@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 19, 2016 at 10:56:40PM +0000, Pedro F. Giffuni wrote: > New Revision: 303047 > URL: https://svnweb.freebsd.org/changeset/base/303047 > > Log: > sed(1): Assorted cleanups and simplifications. > > Const-ify several variables, make it build cleanly with WARNS level 5. > > Submitted by: mi > PR: 195929 > MFC after: 1 month Hi Pedro, This change causes `games/openttd' to fail now, because the generated `$wrkdir/openttd-1.6.1/objs/release/Makefile' file is broken (SRCS var is set to bogus value, search for ^SRCS). Reverting usr.bin/sed back to r303046 fixes it. The latest revision (with ngie@'s fix) exhibits the same problem. Now the port uses somewhat obscure build system, but the sed(1) magic happens inside generate_foo() functions using SRC_REPLACE variable set in make_sed() inside `config.lib' file; these functions are called by the configure script. Would you or Mikhail mind taking a look? Thanks, ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160802141738.GA84154>