Date: Mon, 23 Nov 1998 03:42:55 -0600 (CST) From: bradley@dunn.org To: FreeBSD-gnats-submit@FreeBSD.ORG Subject: kern/8817: -Wtrigraphs cleanup Message-ID: <199811230942.DAA05732@magnate.dunn.org>
index | next in thread | raw e-mail
>Number: 8817
>Category: kern
>Synopsis: Patches to silence -Wtrigraphs
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Mon Nov 23 01:50:01 PST 1998
>Last-Modified:
>Originator: Bradley Dunn
>Organization:
>Release: FreeBSD 3.0-CURRENT i386
>Environment:
>Description:
The attached patches silence -Wtrigraphs.
>How-To-Repeat:
>Fix:
--- src/sys/kern/vfs_bio.c.old Mon Nov 23 03:15:36 1998
+++ src/sys/kern/vfs_bio.c Mon Nov 23 03:16:40 1998
@@ -1739,7 +1739,7 @@
m = bp->b_pages[pageindex];
#ifdef VFS_BIO_DIAG
if (m->pindex != objoff)
- panic("allocbuf: page changed offset??!!!?");
+ panic("allocbuf: page changed offset?!!!?");
#endif
bytesinpage = tinc;
if (tinc > (newbsize - toff))
--- src/sys/nfs/nfs_socket.c.old Mon Nov 23 03:17:21 1998
+++ src/sys/nfs/nfs_socket.c Mon Nov 23 03:18:04 1998
@@ -404,11 +404,11 @@
* For the client side:
* - return EINTR if the RPC is terminated, 0 otherwise
* - set R_MUSTRESEND if the send fails for any reason
- * - do any cleanup required by recoverable socket errors (???)
+ * - do any cleanup required by recoverable socket errors (?)
* For the server side:
* - return EINTR or ERESTART if interrupted by a signal
* - return EPIPE if a connection is lost for connection based sockets (TCP...)
- * - do any cleanup required by recoverable socket errors (???)
+ * - do any cleanup required by recoverable socket errors (?)
*/
int
nfs_send(so, nam, top, rep)
@@ -470,7 +470,7 @@
log(LOG_INFO, "nfsd send error %d\n", error);
/*
- * Handle any recoverable (soft) socket errors here. (???)
+ * Handle any recoverable (soft) socket errors here. (?)
*/
if (error != EINTR && error != ERESTART &&
error != EWOULDBLOCK && error != EPIPE)
--- src/sys/pci/if_de.c.old Mon Nov 23 03:19:05 1998
+++ src/sys/pci/if_de.c Mon Nov 23 03:19:13 1998
@@ -2860,7 +2860,7 @@
* Some folks don't use the standard ethernet rom format
* but instead just put the address in the first 6 bytes
* of the rom and let the rest be all 0xffs. (Can we say
- * ZNYX???) (well sometimes they put in a checksum so we'll
+ * ZNYX?) (well sometimes they put in a checksum so we'll
* start at 8).
*/
for (idx = 8; idx < 32; idx++) {
--- src/sys/pci/ncr.c.old Mon Nov 23 03:19:36 1998
+++ src/sys/pci/ncr.c Mon Nov 23 03:20:19 1998
@@ -7116,7 +7116,7 @@
#define TKR_ADPT_ACTNEG 0x08
#define TKR_ADPT_NOSEEK 0x10
#define TKR_ADPT_MORLUN 0x20
- u_char delay; /* unit ? (table ???) */
+ u_char delay; /* unit ? (table ?) */
u_char tags; /* use 4 times as many ... */
u_char filler[60];
};
--- src/sys/i386/isa/if_le.c.old Mon Nov 23 03:20:59 1998
+++ src/sys/i386/isa/if_le.c Mon Nov 23 03:21:13 1998
@@ -1126,7 +1126,7 @@
/*
* The first four bytes of each transmit buffer are for
* control information. The first byte is the control
- * byte, then the length (why not word aligned??), then
+ * byte, then the length (why not word aligned?), then
* the off to the buffer.
*/
--- src/sys/i386/isa/pcvt/pcvt_kbd.c.old Mon Nov 23 03:21:57 1998
+++ src/sys/i386/isa/pcvt/pcvt_kbd.c Mon Nov 23 03:22:53 1998
@@ -2392,7 +2392,7 @@
{
if(vsp->vt_pure_mode == M_PUREVT
|| (vsp->which_fkl == USR_FKL))
- more_chars = (u_char *)"\033[35~"; /* F21 ??!! */
+ more_chars = (u_char *)"\033[35~"; /* F21 ?!?! */
}
}
--- src/sys/i386/isa/ppc.c.old Mon Nov 23 03:23:30 1998
+++ src/sys/i386/isa/ppc.c Mon Nov 23 03:23:47 1998
@@ -1288,7 +1288,7 @@
* Semantics of clearing EPP timeout bit.
* PC87332 - reading SPP_STR does it...
* SMC - write 1 to EPP timeout bit XXX
- * Others - (???) write 0 to EPP timeout bit
+ * Others - (?) write 0 to EPP timeout bit
*/
static void
ppc_reset_epp_timeout(int unit)
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199811230942.DAA05732>