Date: Wed, 14 Dec 2016 21:29:12 +0000 (UTC) From: Kristof Provost <kp@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: svn commit: r310093 - stable/11/sys/netpfil/pf Message-ID: <201612142129.uBELTCJW023667@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: kp Date: Wed Dec 14 21:29:12 2016 New Revision: 310093 URL: https://svnweb.freebsd.org/changeset/base/310093 Log: MFC r309563: pflog: Correctly initialise subrulenr subrulenr is considered unset if it's set to -1, not if it's set to 1. See contrib/tcpdump/print-pflog.c pflog_print() for a user. This caused incorrect pflog output (tcpdump -n -e -ttt -i pflog0): rule 0..16777216(match) instead of the correct output of rule 0/0(match) PR: 214832 Submitted by: andywhite@gmail.com Modified: stable/11/sys/netpfil/pf/if_pflog.c Directory Properties: stable/11/ (props changed) Modified: stable/11/sys/netpfil/pf/if_pflog.c ============================================================================== --- stable/11/sys/netpfil/pf/if_pflog.c Wed Dec 14 21:26:43 2016 (r310092) +++ stable/11/sys/netpfil/pf/if_pflog.c Wed Dec 14 21:29:12 2016 (r310093) @@ -221,7 +221,7 @@ pflog_packet(struct pfi_kif *kif, struct if (am == NULL) { hdr.rulenr = htonl(rm->nr); - hdr.subrulenr = 1; + hdr.subrulenr = -1; } else { hdr.rulenr = htonl(am->nr); hdr.subrulenr = htonl(rm->nr);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201612142129.uBELTCJW023667>