Date: Wed, 6 Oct 2004 02:06:11 +0000 (UTC) From: Greg Lehey <grog@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/kern vfs_subr.c Message-ID: <200410060206.i9626BM1098239@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
grog 2004-10-06 02:06:11 UTC
FreeBSD src repository
Modified files:
sys/kern vfs_subr.c
Log:
getnewvnode: Weaken the panic "cleaned vnode isn't" to a warning.
Discussion: this panic (or waning) only occurs when the kernel is
compiled with INVARIANTS. Otherwise the problem (which means that
the vp->v_data field isn't NULL, and represents a coding error and
possibly a memory leak) is silently ignored by setting it to NULL
later on.
Panicking here isn't very helpful: by this time, we can only find
the symptoms. The panic occurs long after the reason for "not
cleaning" has been forgotten; in the case in point, it was the
result of severe file system corruption which left the v_type field
set to VBAD. That issue will be addressed by a separate commit.
Revision Changes Path
1.529 +3 -1 src/sys/kern/vfs_subr.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200410060206.i9626BM1098239>