Date: Fri, 19 Feb 1999 13:18:28 +0000 (GMT) From: Doug Rabson <dfr@nlsystems.com> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: Julian Elischer <julian@whistle.com>, Kirk McKusick <mckusick@McKusick.COM>, Jake <jake@checker.org>, Don Lewis <Don.Lewis@tsc.tdk.com>, current@freebsd.org Subject: Re: softupdate panic, anyone seen this? (fwd) Message-ID: <Pine.BSF.4.05.9902191314580.67530-100000@herring.nlsystems.com> In-Reply-To: <199902191043.CAA31641@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 19 Feb 1999, Matthew Dillon wrote: > This may or may not be related. In tracking down the sched_sync() > panic I found two bugs. > > First, a couple of places where the worklist was not being protected > at splbio(). I'm not 100% sure that this is a problem but the code > is complex enough that it's just too dangerous not to do it. > > Second, a double LIST_REMOVE() was being performed in the case where > VOP_FSYNC() would fail to sync all the dirty pages. This can occur > legally for both NFS and filesystems with SOFTUPDATES set. > > I'd appreciate it if someone could verify the double LIST_REMOVE() > bug. vn_syncer_add_to_worklist() already removes the vn from > the list ( assuming the VONWORKLIST v_flag is set, which it should be > in this case ). Your fixes for both problems look fine to me. -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 442 9037 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.05.9902191314580.67530-100000>