Date: Mon, 30 Jul 2018 07:23:59 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 230179] textproc/luaexpat: fails test script on lua 5.3 Message-ID: <bug-230179-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D230179 Bug ID: 230179 Summary: textproc/luaexpat: fails test script on lua 5.3 Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: lx@FreeBSD.org Reporter: andrew@tao11.riddles.org.uk Flags: maintainer-feedback?(lx@FreeBSD.org) Assignee: lx@FreeBSD.org Created attachment 195622 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D195622&action= =3Dedit Makefile patch The supposed "fix" for luaexpat in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D224644 is incorrect, an= d this is easily demonstrated by running the test.lua script included in the module source. The most reasonable fix seems to be this (in addition to removing the incor= rect LUA_32BITS): MAKE_ARGS+=3D COMMON_CFLAGS=3D"-Wall" (i.e. removing options -g -O2 -ansi -pedantic -fPIC -DPIC from the makefile; -fPIC is added back from CFLAGS already, and debug/optimization flags are likewise supposed to come from the port CFLAGS.) Another option that works would be to use -std=3Dc99, but I think the above method is better (and I have checked that the test script runs ok on lua 5.1 and 5.2 still). Patch attached. (I also added a LICENSE=3DMIT - see the doc/us/license.html= in the distribution) --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-230179-7788>