Date: Mon, 10 May 2021 00:44:45 +0200 From: Adriaan de Groot <adridg@freebsd.org> To: "Matthew D. Fuller" <fullermd@over-yonder.net> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 1c31059e3d12 - main - x11-wm/twm: generate synthetic WM hints when needed Message-ID: <5586518.Zv9zXsTiuT@beastie.bionicmutton.org> In-Reply-To: <YJhPPdLhOwH0CU94@over-yonder.net> References: <202105042311.144NB1gG091594@gitrepo.freebsd.org> <YJhPPdLhOwH0CU94@over-yonder.net>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Sunday, 9 May 2021 23:08:13 CEST Matthew D. Fuller wrote: > > This is based on a patch from Reddit > > For anybody researching, this presumably comes from the vtwm patch > > https://sourceforge.net/p/vtwm/code/ci/f50508e8b71d6d874229ad3273cf821307d61 > 94b/ > > which was a cut-down version of the ctwm fix > > https://bazaar.launchpad.net/~ctwm/ctwm/trunk/revision/558 > > > (eventually things work their way upstream ;) Hey, upstream! Yes, that looks mighty familiar. I did cut it down some more (I agree with your r558 about dropping now-unnecessary checks for a NULL wmhints, but frankly the less time I spend looking at C code, the better for me). I'm a bit confused by the "XXX Revisit?" comment and then lines 349-351, which set wmhints->input=True .. something that that "revisit" line has already done unconditionally. Anyway, let's just hope for a new twm release this century that picks this up, so that you can run Chromium (why?) in twm (that trusty fallback). I'll add the upstream reference to the patch. [ade] [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQGzBAABCAAdFiEEhrjttu2OP5apuuy1z93JbxKxkVwFAmCYZd0ACgkQz93JbxKx kVxwPQv/cRX85uIHp65Aqf9MfdU6We44EpoasN/fPcdKv6WuDupPp2m8/eel4al3 Pi6zYfnHFrtwnkxwiy5CqO7tN7+m0qgRBTq2438qlEfAYN2MLjzVRqFxHmJ86Rtt B1uepIUiQ9xzqUiE+8BXiWScDikIUxhOikJaI3tVffWtdyr65eNLuvlMLMhSFDdC cbCFUAbyf0L666So2jP+IfuIstxKxlKEEb19lRsU63DzdVPEW3NxR5o9U8O2EBcv jhltrH5nMKP94QFCcC1fkophFcKYESCiKsZ4dx2KwPTWAUjesB/lI25wNe/83tVc 1cXpoJEEnEZab9ANgMEpSKfGu+xy+ligVsGK6TOmFJnm+Z2V+zHpz12lorE5Bdah hd9IVb3kMrqXAsdiVtKHIbqfaWwteNcALDBsZdyylnUq/9yJclbj6AxcO+WzqYNy AYsUhghianFcKeYb8da5pPA4yodDeSdbSKo389BbYBfdS4LG97c+5/hzifgOJkbW 5i2FJfsC =NHxk -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5586518.Zv9zXsTiuT>