Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 24 Jun 2014 15:28:09 +0000 (UTC)
From:      Craig Rodrigues <rodrigc@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-9@freebsd.org
Subject:   svn commit: r267821 - stable/9/sys/x86/acpica
Message-ID:  <201406241528.s5OFS9dY077521@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: rodrigc
Date: Tue Jun 24 15:28:09 2014
New Revision: 267821
URL: http://svnweb.freebsd.org/changeset/base/267821

Log:
  MFC r263795:
  
  Strict value checking will cause problem.
  Bay trail DN2820FYKH is supported on Linux but does not work on FreeBSD.
  This behaviour is bug-compatible with Linux-3.13.5.
  
  References:
  http://d.hatena.ne.jp/syuu1228/20140326
  http://lxr.linux.no/linux+v3.13.5/arch/x86/kernel/acpi/boot.c#L1094
  
  Submitted by: syuu
  PR: 187966

Modified:
  stable/9/sys/x86/acpica/madt.c
Directory Properties:
  stable/9/sys/   (props changed)

Modified: stable/9/sys/x86/acpica/madt.c
==============================================================================
--- stable/9/sys/x86/acpica/madt.c	Tue Jun 24 15:16:55 2014	(r267820)
+++ stable/9/sys/x86/acpica/madt.c	Tue Jun 24 15:28:09 2014	(r267821)
@@ -306,10 +306,11 @@ interrupt_polarity(UINT16 IntiFlags, UIN
 	case ACPI_MADT_POLARITY_ACTIVE_HIGH:
 		return (INTR_POLARITY_HIGH);
 	case ACPI_MADT_POLARITY_ACTIVE_LOW:
-		return (INTR_POLARITY_LOW);
+		break;
 	default:
-		panic("Bogus Interrupt Polarity");
+		printf("WARNING: Bogus Interrupt Polarity. Assume POLALITY LOW");
 	}
+	return (INTR_POLARITY_LOW);
 }
 
 static enum intr_trigger
@@ -325,10 +326,13 @@ interrupt_trigger(UINT16 IntiFlags, UINT
 	case ACPI_MADT_TRIGGER_EDGE:
 		return (INTR_TRIGGER_EDGE);
 	case ACPI_MADT_TRIGGER_LEVEL:
-		return (INTR_TRIGGER_LEVEL);
+		break;
 	default:
-		panic("Bogus Interrupt Trigger Mode");
+		printf("WARNING: Bogus Interrupt Trigger Mode. Assume Level trigger.");
+		
+		break;
 	}
+	return (INTR_TRIGGER_LEVEL);
 }
 
 /*



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201406241528.s5OFS9dY077521>