Date: Fri, 15 Apr 2016 07:22:51 -0600 From: Warner Losh <imp@bsdimp.com> To: Tommi Pernila <tommi.pernila@iki.fi> Cc: Steven Hartland <killing@multiplay.co.uk>, "freebsd-current@freebsd.org" <freebsd-current@freebsd.org> Subject: Re: Samsung SSD TRIM [Was: Heads up] Message-ID: <E3D8FA38-1B07-4526-9BBD-AF727D81C6F6@bsdimp.com> In-Reply-To: <CABHD1wS2ST1QWU8upS3Ua52NXcD6n4cN_AF%2B-_yvoLb93N_6TA@mail.gmail.com> References: <CANCZdfpnYnVrvhNagYUT9RhAuC1AMCrxh=GCt8RKT0bqxuJybw@mail.gmail.com> <alpine.BSF.2.20.1604142154240.8359@wonkity.com> <CANCZdfqEWDLrHndKf8ZND1mM7spK9cq%2BnfnA79EVEaSj-MJfFA@mail.gmail.com> <57109CB7.3020204@FreeBSD.org> <20160415081130.GH2282@home.opsec.eu> <5710CE6F.6010408@multiplay.co.uk> <CABHD1wS2ST1QWU8upS3Ua52NXcD6n4cN_AF%2B-_yvoLb93N_6TA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Apr 15, 2016, at 7:14 AM, Tommi Pernila <tommi.pernila@iki.fi> wrote: > > Hi, > > On Friday, 15 April 2016, Steven Hartland <killing@multiplay.co.uk> wrote: > >> On 15/04/2016 09:11, Kurt Jaeger wrote: >> >>> Hi! >>> >>> avg wrote: >>> >>>> For what it's worth, I have been using the following SSDs since >>>> September of 2015 : >>>> >>>> ada2: <Samsung SSD 850 EVO 120GB EMT01B6Q> ACS-2 ATA SATA 3.x device >>>> ada3: <Samsung SSD 850 EVO 120GB EMT01B6Q> ACS-2 ATA SATA 3.x device >>>> >>> I have one in use with zfs and trim: >>> >>> ada1: <Samsung SSD 840 EVO 250GB EXT0BB6Q> ACS-2 ATA SATA 3.x device >>> >>> Works as my ports build hosts, and is fine as far as I can see. >>> >>> Prior to Warners commit there was no NCQ TRIM support in FreeBSD, so >> while it was working with standard non-NCQ TRIM (and I can corroborate that >> as we use the 840's and 850's all over with ZFS with TRIM enabled) its >> possible that it could cause issues when NCQ TRIM comes into play. >> >> From what I read when this issue first came to light, I believe the actual >> issue was a Linux kernel bug not a FW bug in Samsung drives that caused the >> corruption. This is the thread which details said issue: >> http://www.spinics.net/lists/raid/msg49440.html >> >> > Here is a link to the commit that fixed the Linux kernel bug. > https://git. > kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=f3f5da624e0a891c34d8cd513c57f1d9b0c7dadc > > Mounting a Samsung SSD with a linux kernel with trim enabled without this > commit can cause issues. Right, that bug allocates space for the TRIM message to be queued. FreeBSD already does that, so that’s not going to be an issue. This was the issue I referred to in a prior message. Both the Samsung 840 and 850 are black listed as far as NCQ trim are concerned. I’ve had other people that have tested them w/o my blacklisted entries, and there are issues at least with the 840 that are firmware related. Warner [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJXEOsrAAoJEGwc0Sh9sBEAhgoQAOa5BxRpUZrfmmMWyh9sAuBR ubXk+mpn9kZDzbuxDxDJgZJisFAaEs2RCcxr4IJNeU7BD41vDTcVBkn7qwYqrqYx fz98TPsqVxJAjzAcAyK3VpFAOueTJlCwACuKYqjUYcYXrvicxTDixS1Cldm1H6Rp r0X2/eT/ub5aMTTtVqPt8P35dgsbRg9Q8I9tHPhsDwniKmS9QXPtC2KeyKwl+/b2 suWr9BGOabPHm8AZSOo63odR70dz5mYpoHtqak5S8obHhC0BNtDD+BGOHiGnep4U 0K7HIds/KcB505HWdk5pvG0mwW5FGjBoagB3mnOiSbXE5Ho2HV6JLqNLm4XEvZVn BW+2TSYZiJ8oKMfw5mplbe/yydaU8kasAYrnALmhl5lv6MDF9N6A5Uax+3TFCw3Z rb+X3hXWv+rQO29mUKVVfoZOWXMwSkmeGVg7a+OZVKgHRBb0abYb/w1E++7oRRGu ZA/FVrLgq8gYo+CcGY7GD+8xY1xW11gGciEnw2ynrLAji3qYccR2kL02q3E/fH9U OWyatoAl5alKdsN+DY16juBPAu+MD3maE4aMwhZjg4dyQaJlKHoZS59SLri6eHEp 8cyf6f4tGqM2gVL+O7BFRMC2fy4Kn4mIk3w95W/C4qT9rj0uuEDhSIguKvrzU8I7 dQKWcCqi80nGmFQVwZ8+ =fKwI -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E3D8FA38-1B07-4526-9BBD-AF727D81C6F6>