Date: Wed, 27 Jan 2021 02:00:49 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Brooks Davis <brooks@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: d89c1c461ce3 - main - Reserve gaps in syscall numbers for local use Message-ID: <YBCtMaFtZWYZ5NBX@kib.kiev.ua> In-Reply-To: <20210126233417.GA6607@spindle.one-eyed-alien.net> References: <202101261828.10QISOKh066392@gitrepo.freebsd.org> <YBCcu0oFxzFSl4Fd@kib.kiev.ua> <20210126233417.GA6607@spindle.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 26, 2021 at 11:34:17PM +0000, Brooks Davis wrote: > On Wed, Jan 27, 2021 at 12:50:35AM +0200, Konstantin Belousov wrote: > > On Tue, Jan 26, 2021 at 06:28:24PM +0000, Brooks Davis wrote: > > > The branch main has been updated by brooks: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=d89c1c461ce31bfc789dbb7bc5f4fce5824c595e > > > > > > commit d89c1c461ce31bfc789dbb7bc5f4fce5824c595e > > > Author: Brooks Davis <brooks@FreeBSD.org> > > > AuthorDate: 2021-01-26 18:27:45 +0000 > > > Commit: Brooks Davis <brooks@FreeBSD.org> > > > CommitDate: 2021-01-26 18:27:45 +0000 > > > > > > Reserve gaps in syscall numbers for local use > > > > > > It is best for auditing of syscalls.master if we only append to the > > > file. Reserving unimplemented system call numbers for local use makes > > > this policy and provides a large set of syscall numbers FreeBSD > > > derivatives can use without risk of conflict. > > > > > > Reviewed by: jhb, kevans, kib > > > Sponsored by: DARPA > > > Differential Revision: https://reviews.freebsd.org/D27988 > > > --- > > > sys/kern/init_sysent.c | 120 +++++++++++++++++++++++------------------------ > > > sys/kern/syscalls.c | 120 +++++++++++++++++++++++------------------------ > > > sys/kern/syscalls.master | 55 ++++++++++------------ > > > 3 files changed, 145 insertions(+), 150 deletions(-) > > I highly dislike this. You committed both manually edited file and generated > > files in one commit. Can we please avoid this? > > > > It is hard/impossible to read the diff as is. > > While in this case it would be harmless to split the changes, I strongly > disagree with the concept of separating syscalls.master changes and > generated files because in the common case (adding syscalls) it requires > that the first commit break the build. That build breakage is a non-issue, even for bisects. Operator just need to move one commit further. But it makes reading the change significantly harder, which is an artificial pain inflicted on everybody who need to follow (and debug) the code. I do not see why it is useful.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YBCtMaFtZWYZ5NBX>