Date: Tue, 12 Apr 2022 19:15:02 -0600 From: Warner Losh <imp@bsdimp.com> To: Ravi Pokala <rpokala@freebsd.org> Cc: Kyle Evans <kevans@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: 454630c72556 - main - stand: libefi: swap /Pci() printing around Message-ID: <CANCZdfpZG_hX=HY-N_4nx6AF0mmt2j9sn4cC2fPDGKUVqcwAgQ@mail.gmail.com> In-Reply-To: <12E7AA6A-F14E-4A34-9807-467A5D1CD251@panasas.com> References: <202204130034.23D0YCPN051666@gitrepo.freebsd.org> <0B5546D3-3623-4348-9AAF-A0AC0E3ACBFC@panasas.com> <CACNAnaFM7KW=BTCfr3t9LN9W_O2a9tenCX2_tTxedP-K-vKwwA@mail.gmail.com> <12E7AA6A-F14E-4A34-9807-467A5D1CD251@panasas.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Tue, Apr 12, 2022, 7:07 PM Ravi Pokala <rpokala@freebsd.org> wrote: > -----Original Message----- > From: Kyle Evans <kevans@freebsd.org> > Date: 2022-04-12, Tuesday at 18:04 > To: Ravi Pokala <rpokala@freebsd.org> > Cc: src-committers <src-committers@freebsd.org>, "< > dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, < > dev-commits-src-main@freebsd.org> > Subject: Re: 454630c72556 - main - stand: libefi: swap /Pci() printing > around > > On Tue, Apr 12, 2022 at 7:57 PM Ravi Pokala <rpokala@freebsd.org> > wrote: > > > > -----Original Message----- > > From: <owner-src-committers@freebsd.org> on behalf of Kyle Evans > <kevans@FreeBSD.org> > > Date: 2022-04-12, Tuesday at 17:34 > > To: <src-committers@FreeBSD.org>, <dev-commits-src-all@FreeBSD.org>, > <dev-commits-src-main@FreeBSD.org> > > Subject: git: 454630c72556 - main - stand: libefi: swap /Pci() > printing around > > > > The branch main has been updated by kevans: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=454630c72556d45e401f29f56b3317c2fb0499a0 > > > > commit 454630c72556d45e401f29f56b3317c2fb0499a0 > > Author: Kyle Evans <kevans@FreeBSD.org> > > AuthorDate: 2022-04-13 00:29:54 +0000 > > Commit: Kyle Evans <kevans@FreeBSD.org> > > CommitDate: 2022-04-13 00:30:30 +0000 > > > > stand: libefi: swap /Pci() printing around > > > > Printing device followed by interface matches, e.g., edk2. > Note that > > this is only a fallback, many firmware implementations will > provide the > > protocol that we'll use to format device paths. > > > > "(device,function)" makes more sense anyway, since that's the > logical organization (i.e. each unique device may have multiple functions). > > > > What was the rationale for doing "(function,device)" in the first > place? > > > > Based on tsoome's reaction when I pointed it out, the rationale was > "whoops" :-) > > That's a perfectly valid rationale! ;-) > Yea, this is a big table of stuff that's tedious to fill in. Since it isn't usually used, the mistake lay dormant. Woops indeed Warner -Ravi (rpokala@) > > > [-- Attachment #2 --] <div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Apr 12, 2022, 7:07 PM Ravi Pokala <<a href="mailto:rpokala@freebsd.org">rpokala@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">-----Original Message-----<br> From: Kyle Evans <<a href="mailto:kevans@freebsd.org" target="_blank" rel="noreferrer">kevans@freebsd.org</a>><br> Date: 2022-04-12, Tuesday at 18:04<br> To: Ravi Pokala <<a href="mailto:rpokala@freebsd.org" target="_blank" rel="noreferrer">rpokala@freebsd.org</a>><br> Cc: src-committers <<a href="mailto:src-committers@freebsd.org" target="_blank" rel="noreferrer">src-committers@freebsd.org</a>>, "<<a href="mailto:dev-commits-src-all@freebsd.org" target="_blank" rel="noreferrer">dev-commits-src-all@freebsd.org</a>>" <<a href="mailto:dev-commits-src-all@freebsd.org" target="_blank" rel="noreferrer">dev-commits-src-all@freebsd.org</a>>, <<a href="mailto:dev-commits-src-main@freebsd.org" target="_blank" rel="noreferrer">dev-commits-src-main@freebsd.org</a>><br> Subject: Re: 454630c72556 - main - stand: libefi: swap /Pci() printing around<br> <br> On Tue, Apr 12, 2022 at 7:57 PM Ravi Pokala <<a href="mailto:rpokala@freebsd.org" target="_blank" rel="noreferrer">rpokala@freebsd.org</a>> wrote:<br> ><br> > -----Original Message-----<br> > From: <<a href="mailto:owner-src-committers@freebsd.org" target="_blank" rel="noreferrer">owner-src-committers@freebsd.org</a>> on behalf of Kyle Evans <kevans@FreeBSD.org><br> > Date: 2022-04-12, Tuesday at 17:34<br> > To: <src-committers@FreeBSD.org>, <dev-commits-src-all@FreeBSD.org>, <dev-commits-src-main@FreeBSD.org><br> > Subject: git: 454630c72556 - main - stand: libefi: swap /Pci() printing around<br> ><br> > The branch main has been updated by kevans:<br> ><br> > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=454630c72556d45e401f29f56b3317c2fb0499a0" rel="noreferrer noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=454630c72556d45e401f29f56b3317c2fb0499a0</a><br>; ><br> > commit 454630c72556d45e401f29f56b3317c2fb0499a0<br> > Author: Kyle Evans <kevans@FreeBSD.org><br> > AuthorDate: 2022-04-13 00:29:54 +0000<br> > Commit: Kyle Evans <kevans@FreeBSD.org><br> > CommitDate: 2022-04-13 00:30:30 +0000<br> ><br> > stand: libefi: swap /Pci() printing around<br> ><br> > Printing device followed by interface matches, e.g., edk2. Note that<br> > this is only a fallback, many firmware implementations will provide the<br> > protocol that we'll use to format device paths.<br> ><br> > "(device,function)" makes more sense anyway, since that's the logical organization (i.e. each unique device may have multiple functions).<br> ><br> > What was the rationale for doing "(function,device)" in the first place?<br> ><br> <br> Based on tsoome's reaction when I pointed it out, the rationale was "whoops" :-)<br> <br> That's a perfectly valid rationale! ;-)<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Yea, this is a big table of stuff that's tedious to fill in. Since it isn't usually used, the mistake lay dormant. Woops indeed</div><div dir="auto"><br></div><div dir="auto">Warner</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> -Ravi (rpokala@)<br> <br> <br> </blockquote></div></div></div>help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpZG_hX=HY-N_4nx6AF0mmt2j9sn4cC2fPDGKUVqcwAgQ>