Date: Wed, 18 Sep 2024 23:10:27 -0400 From: Adam Weinberger <adamw@adamw.org> To: Po-Chuan Hsieh <sunpoet@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: c41e1ace8e98 - main - ftp/curl: Add LIBUV option Message-ID: <CAP7rwcjH5vs-eKtM8=nmfbB9nh_9YPrktfubY7Jt1FL6nMvU_g@mail.gmail.com> In-Reply-To: <202409180619.48I6J0G7032519@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Wed, Sep 18, 2024 at 2:19 AM Po-Chuan Hsieh <sunpoet@freebsd.org> wrote: > The branch main has been updated by sunpoet: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=c41e1ace8e986493e3fc0b22fa0461aa098182e0 > > commit c41e1ace8e986493e3fc0b22fa0461aa098182e0 > Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > AuthorDate: 2024-09-18 05:55:59 +0000 > Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > CommitDate: 2024-09-18 06:13:08 +0000 > > ftp/curl: Add LIBUV option > --- > ftp/curl/Makefile | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/ftp/curl/Makefile b/ftp/curl/Makefile > index 0eebfd2224dd..8bacab43595b 100644 > --- a/ftp/curl/Makefile > +++ b/ftp/curl/Makefile > @@ -41,7 +41,7 @@ CPE_VENDOR= haxx > > SHEBANG_FILES= */*.pl > > -OPTIONS_DEFINE= ALTSVC BROTLI COOKIES CURL_DEBUG DEBUG DOCS > EXAMPLES IDN IPV6 NTLM PROXY PSL STATIC TLS_SRP ZSTD > +OPTIONS_DEFINE= ALTSVC BROTLI COOKIES CURL_DEBUG DEBUG DOCS > EXAMPLES IDN IPV6 LIBUV NTLM PROXY PSL STATIC TLS_SRP ZSTD > OPTIONS_GROUP= PROTOCOL > OPTIONS_RADIO= SSL > OPTIONS_SINGLE= GSSAPI RESOLV > @@ -123,6 +123,8 @@ LIBSSH_CONFIGURE_WITH= libssh > LIBSSH_LIB_DEPENDS= libssh.so:security/libssh > LIBSSH2_CONFIGURE_WITH= libssh2 > LIBSSH2_LIB_DEPENDS= libssh2.so:security/libssh2 > +LIBUV_CONFIGURE_WITH= libuv > +LIBUV_LIB_DEPENDS= libuv.so:devel/libuv > MQTT_CONFIGURE_ENABLE= mqtt > NTLM_CONFIGURE_ENABLE= ntlm > OPENSSL_CONFIGURE_ON= --with-ca-fallback > Hi, Po-Chuan! There's no description for this new LIBUV option, so I was unclear what libuv did for Curl. In upstream's configure.ac, it has this: dnl ********************************************************************** dnl libuv is only ever used for debug purposes dnl ********************************************************************** ... if test X"$want_libuv" != Xno; then if test x$want_debug != xyes; then AC_MSG_ERROR([Using libuv without debug support enabled is useless]) fi So, the LIBUV option *must* be used with the DEBUG option. If linking against libuv is going to be important for end-users, we probably want LIBUV_IMPLIES=DEBUG. # Adam -- Adam Weinberger adamw@adamw.org https://www.adamw.org [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:arial,sans-serif">On Wed, Sep 18, 2024 at 2:19 AM Po-Chuan Hsieh <<a href="mailto:sunpoet@freebsd.org">sunpoet@freebsd.org</a>> wrote:</div></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The branch main has been updated by sunpoet:<br> <br> URL: <a href="https://cgit.FreeBSD.org/ports/commit/?id=c41e1ace8e986493e3fc0b22fa0461aa098182e0" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=c41e1ace8e986493e3fc0b22fa0461aa098182e0</a><br>; <br> commit c41e1ace8e986493e3fc0b22fa0461aa098182e0<br> Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org><br> AuthorDate: 2024-09-18 05:55:59 +0000<br> Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org><br> CommitDate: 2024-09-18 06:13:08 +0000<br> <br> ftp/curl: Add LIBUV option<br> ---<br> ftp/curl/Makefile | 4 +++-<br> 1 file changed, 3 insertions(+), 1 deletion(-)<br> <br> diff --git a/ftp/curl/Makefile b/ftp/curl/Makefile<br> index 0eebfd2224dd..8bacab43595b 100644<br> --- a/ftp/curl/Makefile<br> +++ b/ftp/curl/Makefile<br> @@ -41,7 +41,7 @@ CPE_VENDOR= haxx<br> <br> SHEBANG_FILES= */*.pl<br> <br> -OPTIONS_DEFINE= ALTSVC BROTLI COOKIES CURL_DEBUG DEBUG DOCS EXAMPLES IDN IPV6 NTLM PROXY PSL STATIC TLS_SRP ZSTD<br> +OPTIONS_DEFINE= ALTSVC BROTLI COOKIES CURL_DEBUG DEBUG DOCS EXAMPLES IDN IPV6 LIBUV NTLM PROXY PSL STATIC TLS_SRP ZSTD<br> OPTIONS_GROUP= PROTOCOL<br> OPTIONS_RADIO= SSL<br> OPTIONS_SINGLE= GSSAPI RESOLV<br> @@ -123,6 +123,8 @@ LIBSSH_CONFIGURE_WITH= libssh<br> LIBSSH_LIB_DEPENDS= libssh.so:security/libssh<br> LIBSSH2_CONFIGURE_WITH= libssh2<br> LIBSSH2_LIB_DEPENDS= libssh2.so:security/libssh2<br> +LIBUV_CONFIGURE_WITH= libuv<br> +LIBUV_LIB_DEPENDS= libuv.so:devel/libuv<br> MQTT_CONFIGURE_ENABLE= mqtt<br> NTLM_CONFIGURE_ENABLE= ntlm<br> OPENSSL_CONFIGURE_ON= --with-ca-fallback<br> </blockquote></div><br clear="all"><div style="font-family:arial,sans-serif" class="gmail_default">Hi, Po-Chuan!</div><div style="font-family:arial,sans-serif" class="gmail_default"><br></div><div style="font-family:arial,sans-serif" class="gmail_default">There's no description for this new LIBUV option, so I was unclear what libuv did for Curl. In upstream's <a href="http://configure.ac">configure.ac</a>, it has this:</div><div style="font-family:arial,sans-serif" class="gmail_default"><br></div><div style="font-family:arial,sans-serif" class="gmail_default">dnl **********************************************************************<br>dnl libuv is only ever used for debug purposes<br>dnl **********************************************************************<br></div><div><br></div><div><div style="font-family:arial,sans-serif" class="gmail_default">...</div><div style="font-family:arial,sans-serif" class="gmail_default"><br></div><div style="font-family:arial,sans-serif" class="gmail_default">if test X"$want_libuv" != Xno; then<br> if test x$want_debug != xyes; then<br> AC_MSG_ERROR([Using libuv without debug support enabled is useless])<br> fi</div><div style="font-family:arial,sans-serif" class="gmail_default"><br></div><div style="font-family:arial,sans-serif" class="gmail_default">So, the LIBUV option *must* be used with the DEBUG option. If linking against libuv is going to be important for end-users, we probably want LIBUV_IMPLIES=DEBUG.</div><div style="font-family:arial,sans-serif" class="gmail_default"><br></div><div style="font-family:arial,sans-serif" class="gmail_default"># Adam</div><div style="font-family:arial,sans-serif" class="gmail_default"><br></div><br></div><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Adam Weinberger</div><div><a href="mailto:adamw@adamw.org" target="_blank">adamw@adamw.org</a></div><div><a href="https://www.adamw.org" target="_blank">https://www.adamw.org</a></div></div></div></div></div></div>;help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAP7rwcjH5vs-eKtM8=nmfbB9nh_9YPrktfubY7Jt1FL6nMvU_g>