Date: 18 Dec 2000 02:59:25 +0100 From: assar@FreeBSD.ORG To: John Baldwin <jhb@FreeBSD.ORG> Cc: Doug Barton <DougB@gorean.org>, freebsd-current@FreeBSD.ORG Subject: Re: Panic with fairly up to date -current, seems NFS related Message-ID: <5lpuiqa3r6.fsf@assaris.sics.se> In-Reply-To: John Baldwin's message of "Sun, 17 Dec 2000 17:17:21 -0800 (PST)" References: <XFMail.001217171721.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin <jhb@FreeBSD.ORG> writes:
> Grog had a similar panic on IRC the other day:
>
> >#7 0xc021c857 in nfs_msg (p=0x0, server=0xc0bf0cf2 "slave:/usr/home",
> > msg=0xc02ba748 "not responding") at
>
> The 'p' parameter is a process that is supposed to be making the request, and
> thus is going to receive a console message to its tty about the server going
> away. Note that 'p' is NULL. This leads to a NULL dereference in tprintf().
> The 'p' comes from some type of NFS request structure. That is as far as I
> could take it however..
Since proc can be NULL and most of the other code in nfs_socket
handles it I do think this actually is the right thing to do.
Comments?
/assar
Index: nfs_socket.c
===================================================================
RCS file: /home/ncvs/src/sys/nfs/nfs_socket.c,v
retrieving revision 1.62
diff -u -w -u -w -r1.62 nfs_socket.c
--- nfs_socket.c 2000/11/26 20:35:21 1.62
+++ nfs_socket.c 2000/12/18 01:58:46
@@ -1969,6 +1969,7 @@
char *server, *msg;
{
+ if (p != NULL)
tprintf(p, LOG_INFO, "nfs server %s: %s\n", server, msg);
return (0);
}
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5lpuiqa3r6.fsf>