Date: Thu, 19 Aug 1999 11:37:15 -0700 (PDT) From: Archie Cobbs <archie@whistle.com> To: dillon@apollo.backplane.com (Matthew Dillon) Cc: bright@rush.net (Alfred Perlstein), eivind@FreeBSD.ORG (Eivind Eklund), peter@FreeBSD.ORG (Peter Wemm), current@FreeBSD.ORG Subject: Re: NFS HEADS UP (was Re: cvs commit: src/sys/nfs nfsm_subs.h xdr_subs.h) Message-ID: <199908191837.LAA95045@bubba.whistle.com> In-Reply-To: <199908191829.LAA57025@apollo.backplane.com> from Matthew Dillon at "Aug 19, 1999 11:29:31 am"
next in thread | previous in thread | raw e-mail | index | archive | help
Matthew Dillon writes: > :On a somewhat similar note, what do you think about converting a lot > :of the NFS macros to functions, yes i know it will be difficult, but > :there is so much forced inlining it just seems like it would reduce > :the codesize signifigantly and play nicer with the CPU cache. > : > :It would also make the code a lot more readable. > : > :Worthwhile exercise? > : > :-Alfred Perlstein - [bright@rush.net|bright@wintelcom.net] > > Well, the issue with converting many of the macros to inline functions > is with the embedded goto's and references to variables defined outside > the macros. Converting them to functions would basically require > rewriting a huge chunk of NFS code. > > This is one of those "If it ain't broke, don't fix it" scenarios, I'm > afraid. It would take too long to redo it all (and remember, I'm the > guy who usually *likes* rewriting code!). As much as I would like to > make NFS more readable, it just isn't worth the effort. It still might be a "worthwhile exercise", if your goal is simply to increase your understanding of the NFS code. -Archie ___________________________________________________________________________ Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199908191837.LAA95045>