Date: Mon, 24 Apr 2006 18:11:03 -0400 From: Kris Kennaway <kris@obsecurity.org> To: Jeremy Chadwick <freebsd@jdc.parodius.com> Cc: cvs-ports@FreeBSD.org, ports-committers@FreeBSD.org, "Andrey A. Chernov" <ache@FreeBSD.org>, cvs-all@FreeBSD.org, Kris Kennaway <kris@obsecurity.org> Subject: Re: cvs commit: ports/graphics/png/files patch-aa Message-ID: <20060424221103.GA19916@xor.obsecurity.org> In-Reply-To: <20060424210548.GA80839@pentarou.parodius.com> References: <200604241404.k3OE49eJ074318@repoman.freebsd.org> <20060424180431.GA13567@xor.obsecurity.org> <20060424210548.GA80839@pentarou.parodius.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--3V7upXqbjpZ4EhLz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, Apr 24, 2006 at 02:05:48PM -0700, Jeremy Chadwick wrote:
> On Mon, Apr 24, 2006 at 02:04:31PM -0400, Kris Kennaway wrote:
> > On Mon, Apr 24, 2006 at 02:04:09PM +0000, Andrey A. Chernov wrote:
> > > ache 2006-04-24 14:04:09 UTC
> > >=20
> > > FreeBSD ports repository
> > >=20
> > > Modified files:
> > > graphics/png/files patch-aa=20
> > > Log:
> > > Use NO_OBJ NO_PROFILE instead of obsoleted their variants
> > > =20
> > > PR: 96244
> > > Submitted by: Jeremy Chadwick <freebsd@jdc.parodius.com>
> >=20
> > Are you sure this works on old FreeBSD branches?
>=20
> No, I did not test this.
>=20
> Kris is right -- chances are it won't suffice for 4.x. The modified
> port builds fine on my 4.x box, but obviously the ports/mk framework
> is expecting NOOBJ and NOPROFILE there. I don't know of a way to
> test this (not sure what NOOBJ does, and profiling is completely
> disabled on all of my machines).
>=20
> One solution for solving this dilemma would be to remove the NOOBJ
> and NOPROFILE lines completely from ${WRKSRC}/scripts/makefile.freebsd
> and utilise a check in the port Makefile for ${OSVERSION}, e.g.
> something like this:
>=20
> .if ${OSVERSION} < 500000
> MAKE_ARGS+=3D -DNOPROFILE -DNOOBJ
> .else
> MAKE_ARGS+=3D -DNO_PROFILE -DNO_OBJ
> .endif
Either that (with correct OSVERSION) or just specify both variants at
once.
Kris
--3V7upXqbjpZ4EhLz
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (FreeBSD)
iD8DBQFETUz3Wry0BWjoQKURAkQQAJ4pF0N6VBLnwcwRDd1VhtICtAUiFACgoSlL
cxyhNCAduCx5vK4lzN24ByI=
=15Cm
-----END PGP SIGNATURE-----
--3V7upXqbjpZ4EhLz--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060424221103.GA19916>