Date: Sun, 16 Apr 2000 09:42:11 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Greg Lehey <grog@lemis.com> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: Current state of Vinum Message-ID: <3836.955870931@critter.freebsd.dk> In-Reply-To: Your message of "Sun, 16 Apr 2000 17:03:06 %2B0930." <20000416170306.J72816@freebie.lemis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20000416170306.J72816@freebie.lemis.com>, Greg Lehey writes: >Yesterday, Poul-Henning Kamp committed a number of changes to the >system which required a number of changes to Vinum code. He sent me >some patches to review with the choice of committing them or breaking >Vinum. I received these patches on a Saturday morning just before >leaving for a day trip. I asked him to do neither, but when I got >back home I found that he had opted for breaking Vinum. These patches have been available on my web-page for 11 days and I have several times tried to solicit your review of the vinum specific part. >5. Any disputed change must be backed out pending resolution of > the dispute if requested by a MAINTAINER or the principal > architect. Security related changes may override a MAINTAINER's > wishes at the Security Officer's discretion. You are not the maintainer for the rest of the kernel, only of vinum. Being maintainer of vinum doesn't give you any veto right over the rest of the kernel. Lacking your permission I left out the changes to vinum and put them on my web page instead and pointed people there until you had time. This is in accordance with that rule as I read it. >10. Test your changes before committing them. There are no test-scripts or test-instructions for vinum. I have asked for these several times offering to add error-simulation code to the md driver in return ("quid pro quid"). All other parts of the kernel which it has been inside my ability to test (and that's actually quite a lot by now) has been tested. >I have decided to take some time off and let >anybody who wants try to fix things. I'm always prepared to review >changes, given reasonable time. Thanks. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD coreteam member | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3836.955870931>