Date: Wed, 6 Sep 2000 19:06:09 +0100 From: Ben Smithurst <ben@FreeBSD.org> To: Jeroen Ruigrok van der Werven <jruigrok@via-net-works.nl> Cc: Paul Richards <paul@netsynergy.co.uk>, Don Lewis <Don.Lewis@tsc.tdk.com>, Don Lewis <truckman@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern init_main.c kern_exec.c kern_exit.ckern_fork.c kern_proc.c kern_prot.c kern_resource.c uipc_socket.cuipc_socket2.c uipc_usrreq.c vfs_aio.c src/sys/sys proc.hresourcevar.h ucred.h Message-ID: <20000906190609.B8064@strontium.scientia.demon.co.uk> In-Reply-To: <20000906084543.A16892@lucifer.bart.nl> References: <200009052211.PAA70424@freefall.freebsd.org> <39B581FE.7E78128B@netsynergy.co.uk> <200009060222.TAA26628@salsa.gv.tsc.tdk.com> <39B5AB9D.63C8938C@netsynergy.co.uk> <20000906084543.A16892@lucifer.bart.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
Jeroen Ruigrok van der Werven wrote: > -On [20000906 04:30], Paul Richards (paul@netsynergy.co.uk) wrote: >> Don Lewis wrote: >>> Maybe the -current version of GENERIC should enable INVARIANTS, for >>> the same reason that we crank up malloc debugging. >> >> I have long advocated enabling INVARIANTS on the current branch. > > I have never encountered a person using CURRENT using a GENERIC kernel. > > On the other hand, it might help when people use GENERIC as kernel > template. However, the real coders probably know the meaning of > INVARIANTS and enable this anyway, and the persons trying CURRENT for > whatever reasons might not know it and just remove it. > > I am not really sure there is an added benefit to adding it to GENERIC. So add something like #if !defined(NO_INVARIANTS) && !defined(INVARIANTS) #define INVARIANTS #ifndef INVARIANT_SUPPORT #define INVARIANT_SUPPORT #endif #endif to an appropriate header file (perhaps opt_global.h or another one auto-generated by config) so it's on by default for all -current kernels unless someone explicitly turns it off. -- Ben Smithurst / ben@FreeBSD.org / PGP: 0x99392F7D To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000906190609.B8064>