Date: Thu, 22 Jun 2006 14:09:20 +0000 (UTC) From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: Hajimu UMEMOTO <ume@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_fw2.c Message-ID: <20060622140842.A60374@maildrop.int.zabbadoz.net> In-Reply-To: <20060622140253.X60374@maildrop.int.zabbadoz.net> References: <200606221322.k5MDMs2X065252@repoman.freebsd.org> <20060622140253.X60374@maildrop.int.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 22 Jun 2006, Bjoern A. Zeeb wrote: > On Thu, 22 Jun 2006, Hajimu UMEMOTO wrote: > >> ume 2006-06-22 13:22:54 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/netinet ip_fw2.c >> Log: >> - Pullup even when the extention header is unknown, to prevent >> infinite loop with net.inet6.ip6.fw.deny_unknown_exthdrs=0. >> - Teach ipv6 and ipencap as they appear in an IPv4/IPv6 over IPv6 >> tunnel. >> - Test the next extention header even when the routing header type >> is unknown with net.inet6.ip6.fw.deny_unknown_exthdrs=0. > > @@ -2189,7 +2189,10 @@ do { > \ > > case IPPROTO_ROUTING: /* RFC 2460 */ > PULLUP_TO(hlen, ulp, struct ip6_rthdr); > - if (((struct ip6_rthdr *)ulp)->ip6r_type != 0) { > + switch (((struct ip6_rthdr *)ulp)->ip6r_type) { > + case 0: > > I think you are missing a > ulp = NULL; > here? Just ignore it. Looks correct. Missed the no double switch when I was interrupted by the 3rd phone call:( -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060622140842.A60374>