Date: Mon, 9 Mar 2026 00:45:33 +0100 From: Daniel Engberg <diizzy@FreeBSD.org> To: Robert Clausecker <fuz@FreeBSD.org>, ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 16eb147bebc3 - main - textproc/comparator: update to 2.14 Message-ID: <d8ad405a-d918-4bca-bce1-9276b9e44ff9@FreeBSD.org> In-Reply-To: <69adf744.3f9be.78cfb1@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
On 2026-03-08 23:25, Robert Clausecker wrote: > The branch main has been updated by fuz: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=16eb147bebc3b183c83c7ea32e1d576b727655a5 > > commit 16eb147bebc3b183c83c7ea32e1d576b727655a5 > Author: Robert Clausecker <fuz@FreeBSD.org> > AuthorDate: 2026-02-28 14:52:28 +0000 > Commit: Robert Clausecker <fuz@FreeBSD.org> > CommitDate: 2026-03-08 22:24:48 +0000 > > textproc/comparator: update to 2.14 > > This fixes a bug discovered on FreeBSD. > > Changelog: https://gitlab.com/esr/comparator/-/blob/master/NEWS.adoc?ref_type=heads > --- > textproc/comparator/Makefile | 6 ++++-- > textproc/comparator/distinfo | 6 +++--- > textproc/comparator/files/patch-Makefile | 21 +++++---------------- > 3 files changed, 12 insertions(+), 21 deletions(-) > > .... > > diff --git a/textproc/comparator/files/patch-Makefile b/textproc/comparator/files/patch-Makefile > index 9d1343fd0847..1c6f30d76325 100644 > --- a/textproc/comparator/files/patch-Makefile > +++ b/textproc/comparator/files/patch-Makefile > @@ -1,22 +1,11 @@ > ---- Makefile.orig 2026-02-10 12:32:33 UTC > +--- Makefile.orig 2026-02-28 14:41:28 UTC > +++ Makefile > -@@ -15,8 +15,8 @@ SOURCES = $(CODE) $(SCRIPTS) $(DOCS) $(EXTRAS) $(TEST) > +@@ -15,7 +15,7 @@ SOURCES = $(CODE) $(SCRIPTS) $(DOCS) $(EXTRAS) $(TEST) > EXTRAS = shredtree.py shredcompare.py > TEST = test > SOURCES = $(CODE) $(SCRIPTS) $(DOCS) $(EXTRAS) $(TEST) Makefile > --CFLAGS = -O3 > --LDFLAGS = > -+CFLAGS ?= -O3 > -+LDFLAGS ?= > +-CFLAGS = -O3 -Wall -Wextra -Werror -fstack-protector-strong -fno-strict-aliasing -DLARGEFILES > ++CFLAGS += -O3 -Wall -Wextra -fstack-protector-strong -fno-strict-aliasing -DLARGEFILES > + LDFLAGS = Hi, This now overrides flags set by ports framework which is a violation. https://docs.freebsd.org/en/books/porters-handbook/book/#dads-cflags Best regards, Danielhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d8ad405a-d918-4bca-bce1-9276b9e44ff9>