Date: Wed, 1 Sep 2004 14:12:26 -0700 From: Brooks Davis <brooks@one-eyed-alien.net> To: "Justin T. Gibbs" <gibbs@scsiguy.com> Cc: src-committers@FreeBSD.org Subject: Re: cvs commit: src/sbin/ifconfig ifconfig.c src/sys/net if.c if.h Message-ID: <20040901211226.GB3754@odin.ac.hmc.edu> In-Reply-To: <73F8DDC079929FAA3D43CA2E@caspian.scsiguy.com> References: <200409011822.i81IMERb017602@repoman.freebsd.org> <73F8DDC079929FAA3D43CA2E@caspian.scsiguy.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--OwLcNYc0lM97+oe1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 01, 2004 at 02:44:45PM -0600, Justin T. Gibbs wrote: >=20 > > brooks 2004-09-01 18:22:14 UTC > >=20 > > FreeBSD src repository > >=20 > > Modified files: > > sbin/ifconfig ifconfig.c=20 > > sys/net if.c if.h=20 > > Log: > > Use a spare byte in struct if_data to store the structure size without > > increasing it. Add code to ifconfig to use this size to find the > > sockaddr_dl after the struct if_data in the routing message. This > > allows struct if_data to grow (up to 255 bytes) without breaking > > ifconfig. >=20 > You could squeeze out 256 bytes if you treat 0 as meaning 256 - just like > the SCSI protocol. Unfortunaly, we're using 0 as the magic, not-set variable. My intent is to add some better hurristics for the 0 case if we do end up keeping this hack. Long term, we probably need to rev the routing message API to fix this kind of junk, but that's a massive undertaking. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --OwLcNYc0lM97+oe1 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFBNjs5XY6L6fI4GtQRAgAIAJ92UwkD6gXAURy3ZcS9RhzpLkpaawCgj9Sx DF3+6mmlXige+lWc1MHwn70= =ekhs -----END PGP SIGNATURE----- --OwLcNYc0lM97+oe1--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040901211226.GB3754>