Date: Wed, 13 Apr 2022 21:03:59 GMT From: Robert Wing <rew@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: d7d8cc989150 - stable/13 - ffs_mount(): return early if namei() fails to lookup disk device Message-ID: <202204132103.23DL3xP2012317@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by rew: URL: https://cgit.FreeBSD.org/src/commit/?id=d7d8cc9891507ec3d2dcd9334be2afade1ed9d0b commit d7d8cc9891507ec3d2dcd9334be2afade1ed9d0b Author: Robert Wing <rew@FreeBSD.org> AuthorDate: 2022-03-07 19:18:03 +0000 Commit: Robert Wing <rew@FreeBSD.org> CommitDate: 2022-04-13 20:59:12 +0000 ffs_mount(): return early if namei() fails to lookup disk device With soft updates enabled, an INVARIANTS panic is hit in ffs_unmount(). The problem occurs in ffs_mount() when upgrading a mount from ro->rw. During a mount update, the soft update code gets set up but doesn't get cleaned up if namei() fails when looking up the disk device. Avoid this scenario by looking up the disk device first and bail early if the namei() lookup fails. PR: 256511 Reviewed by: mckusick, kib Differential Revision: https://reviews.freebsd.org/D30870 (cherry picked from commit 0455cc7104ec8e8dd54b3f44049112a5a8ca329c) --- sys/ufs/ffs/ffs_vfsops.c | 148 +++++++++++++++++++++++------------------------ 1 file changed, 72 insertions(+), 76 deletions(-) diff --git a/sys/ufs/ffs/ffs_vfsops.c b/sys/ufs/ffs/ffs_vfsops.c index 89fdc4336834..2eae7c5fa630 100644 --- a/sys/ufs/ffs/ffs_vfsops.c +++ b/sys/ufs/ffs/ffs_vfsops.c @@ -436,15 +436,84 @@ ffs_mount(struct mount *mp) mp->mnt_kern_flag &= ~MNTK_FPLOOKUP; mp->mnt_flag |= mntorflags; MNT_IUNLOCK(mp); + + /* + * Must not call namei() while owning busy ref. + */ + if (mp->mnt_flag & MNT_UPDATE) + vfs_unbusy(mp); + + /* + * Not an update, or updating the name: look up the name + * and verify that it refers to a sensible disk device. + */ + NDINIT(&ndp, LOOKUP, FOLLOW | LOCKLEAF, UIO_SYSSPACE, fspec, td); + error = namei(&ndp); + if ((mp->mnt_flag & MNT_UPDATE) != 0) { + /* + * Unmount does not start if MNT_UPDATE is set. Mount + * update busies mp before setting MNT_UPDATE. We + * must be able to retain our busy ref successfully, + * without sleep. + */ + error1 = vfs_busy(mp, MBF_NOWAIT); + MPASS(error1 == 0); + } + if (error != 0) + return (error); + NDFREE(&ndp, NDF_ONLY_PNBUF); + if (!vn_isdisk_error(ndp.ni_vp, &error)) { + vput(ndp.ni_vp); + return (error); + } + /* - * If updating, check whether changing from read-only to - * read/write; if there is no device name, that's all we do. + * If mount by non-root, then verify that user has necessary + * permissions on the device. + */ + accmode = VREAD; + if ((mp->mnt_flag & MNT_RDONLY) == 0) + accmode |= VWRITE; + error = VOP_ACCESS(ndp.ni_vp, accmode, td->td_ucred, td); + if (error) + error = priv_check(td, PRIV_VFS_MOUNT_PERM); + if (error) { + vput(ndp.ni_vp); + return (error); + } + + /* + * New mount + * + * We need the name for the mount point (also used for + * "last mounted on") copied in. If an error occurs, + * the mount point is discarded by the upper level code. + * Note that vfs_mount_alloc() populates f_mntonname for us. */ - if (mp->mnt_flag & MNT_UPDATE) { + if ((mp->mnt_flag & MNT_UPDATE) == 0) { + if ((error = ffs_mountfs(ndp.ni_vp, mp, td)) != 0) { + vrele(ndp.ni_vp); + return (error); + } + } else { + /* + * When updating, check whether changing from read-only to + * read/write; if there is no device name, that's all we do. + */ ump = VFSTOUFS(mp); fs = ump->um_fs; odevvp = ump->um_odevvp; devvp = ump->um_devvp; + + /* + * If it's not the same vnode, or at least the same device + * then it's not correct. + */ + if (ndp.ni_vp->v_rdev != ump->um_odevvp->v_rdev) + error = EINVAL; /* needs translation */ + vput(ndp.ni_vp); + if (error) + return (error); if (fs->fs_ronly == 0 && vfs_flagopt(mp->mnt_optnew, "ro", NULL, 0)) { /* @@ -647,79 +716,6 @@ ffs_mount(struct mount *mp) */ if (mp->mnt_flag & MNT_SNAPSHOT) return (ffs_snapshot(mp, fspec)); - - /* - * Must not call namei() while owning busy ref. - */ - vfs_unbusy(mp); - } - - /* - * Not an update, or updating the name: look up the name - * and verify that it refers to a sensible disk device. - */ - NDINIT(&ndp, LOOKUP, FOLLOW | LOCKLEAF, UIO_SYSSPACE, fspec, td); - error = namei(&ndp); - if ((mp->mnt_flag & MNT_UPDATE) != 0) { - /* - * Unmount does not start if MNT_UPDATE is set. Mount - * update busies mp before setting MNT_UPDATE. We - * must be able to retain our busy ref succesfully, - * without sleep. - */ - error1 = vfs_busy(mp, MBF_NOWAIT); - MPASS(error1 == 0); - } - if (error != 0) - return (error); - NDFREE(&ndp, NDF_ONLY_PNBUF); - devvp = ndp.ni_vp; - if (!vn_isdisk_error(devvp, &error)) { - vput(devvp); - return (error); - } - - /* - * If mount by non-root, then verify that user has necessary - * permissions on the device. - */ - accmode = VREAD; - if ((mp->mnt_flag & MNT_RDONLY) == 0) - accmode |= VWRITE; - error = VOP_ACCESS(devvp, accmode, td->td_ucred, td); - if (error) - error = priv_check(td, PRIV_VFS_MOUNT_PERM); - if (error) { - vput(devvp); - return (error); - } - - if (mp->mnt_flag & MNT_UPDATE) { - /* - * Update only - * - * If it's not the same vnode, or at least the same device - * then it's not correct. - */ - - if (devvp->v_rdev != ump->um_devvp->v_rdev) - error = EINVAL; /* needs translation */ - vput(devvp); - if (error) - return (error); - } else { - /* - * New mount - * - * We need the name for the mount point (also used for - * "last mounted on") copied in. If an error occurs, - * the mount point is discarded by the upper level code. - * Note that vfs_mount_alloc() populates f_mntonname for us. - */ - if ((error = ffs_mountfs(devvp, mp, td)) != 0) { - vrele(devvp); - return (error); - } } MNT_ILOCK(mp);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202204132103.23DL3xP2012317>