Date: Thu, 03 Jan 2008 09:55:34 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: andrew@freebsd.org Cc: perforce@freebsd.org Subject: Re: PERFORCE change 132385 for review Message-ID: <20080103.095534.-1820226863.imp@bsdimp.com> In-Reply-To: <200801031015.m03AFSNS026302@repoman.freebsd.org> References: <200801031015.m03AFSNS026302@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <200801031015.m03AFSNS026302@repoman.freebsd.org>
Andrew Turner <andrew@freebsd.org> writes:
: http://perforce.freebsd.org/chv.cgi?CH=132385
:
: Change 132385 by andrew@andrew_hermies on 2008/01/03 10:15:21
:
: Add the start of a NAND driver based on one written by John Birrell (jb@)
You better make sure that you can use it. At timing solutions, we
were told not to distribute it without telling John Birrell first and
getting his permission. There was some problem with the code he
wanted to get corrected. Not sure if it was technical or political or
license, but he did ask us not to distribute it. John Hein should not
have published it.
Also, the driver needs to be split into a machine specific NAND
"bridge" part and a nand protocol part. We need similar things for
NOR memory and a few others.
Warner
: Affected files ...
:
: .. //depot/projects/arm/src/sys/arm/s3c2xx0/files.s3c2xx0#3 edit
: .. //depot/projects/arm/src/sys/arm/s3c2xx0/s3c2410.c#7 edit
: .. //depot/projects/arm/src/sys/arm/s3c2xx0/s3c2410reg.h#2 edit
: .. //depot/projects/arm/src/sys/arm/s3c2xx0/s3c24x0_nand.c#1 add
:
: Differences ...
:
: ==== //depot/projects/arm/src/sys/arm/s3c2xx0/files.s3c2xx0#3 (text+ko) ====
:
: @@ -4,6 +4,7 @@
: arm/s3c2xx0/s3c2410.c standard
: arm/s3c2xx0/s3c2xx0_space.c standard
: arm/s3c2xx0/s3c24x0_clk.c standard
: +arm/s3c2xx0/s3c24x0_nand.c optional nand
: arm/s3c2xx0/uart_bus_s3c2410.c optional uart
: arm/s3c2xx0/uart_cpu_s3c2410.c optional uart
: arm/s3c2xx0/uart_dev_s3c2410.c optional uart
:
: ==== //depot/projects/arm/src/sys/arm/s3c2xx0/s3c2410.c#7 (text+ko) ====
:
: @@ -200,6 +200,7 @@
: rman_manage_region(&s3c2xx0_softc->s3c2xx0_rman, 0, 32) != 0)
: panic("s3c2410_attach: failed to set up rman");
: device_add_child(dev, "timer", 0);
: + device_add_child(dev, "nand", 0);
: bus_generic_probe(dev);
: bus_generic_attach(dev);
:
:
: ==== //depot/projects/arm/src/sys/arm/s3c2xx0/s3c2410reg.h#2 (text+ko) ====
:
: @@ -141,10 +141,17 @@
:
: /* NAND Flash controller */
: #define NANDFC_NFCONF 0x00 /* Configuration */
: +#define NFCONF_ENABLE (1<<15) /* NAND controller enabled */
: +#define NFCONF_ECC (1<<12) /* Initialize ECC decoder/encoder */
: +#define NFCONF_FCE (1<<11) /* Flash chip enabled */
: +#define NFCONF_TACLS (7<<8) /* CLE and ALE duration */
: +#define NFCONF_TWRPH0 (7<<4) /* TWRPH0 duration */
: +#define NFCONF_TWRPH1 (7<<0) /* TWRPH1 duration */
: #define NANDFC_NFCMD 0x04 /* command */
: #define NANDFC_NFADDR 0x08 /* address */
: #define NANDFC_NFDATA 0x0c /* data */
: #define NANDFC_NFSTAT 0x10 /* operation status */
: +#define NFSTAT_READY (1<<0) /* NAND flash memory ready/busy status */
: #define NANDFC_NFECC 0x14 /* ecc */
:
: /* GPIO */
:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080103.095534.-1820226863.imp>