Date: Wed, 03 Feb 1999 19:03:39 -0800 From: "Jordan K. Hubbard" <jkh@zippy.cdrom.com> To: asami@FreeBSD.ORG (Satoshi Asami) Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/etc make.conf Message-ID: <16187.918097419@zippy.cdrom.com> In-Reply-To: Your message of "Wed, 03 Feb 1999 18:44:18 PST." <199902040244.SAA25685@silvia.hip.berkeley.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
> * I already address this question above - please read the paragraph
> * again *more carefully*. Thanks.
>
> Sorry, I read it again don't see any answer to pkg_add or sysinstall.
Argh. The point the whole paragraph makes is that we're not talking
about *just* an environment variable and hence pkg_add and sysinstall
don't even really enter into this discussion. It's just a "well known
knob" as far as that's concerned, and one which happens to work for
both of the above (or any other consumer of libfetch) if set in the
environment.
> You said "add -p to FETCH_BEFORE_ARGS" which implies the patch you are
> talking about is to bsd.port.mk. And then you say "to have *it*
> (emphasis mine) work for ... environment OR in /etc/make.conf", which
> means *it* should work if you set it in /etc/make.conf but not in your
> environment.
Actually -P, -p was a typo, but yes. :) If the variable had not
suddenly disappeared from make.conf, my next step was to send you
the following diff:
Index: bsd.port.mk
===================================================================
RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.303
diff -u -u -r1.303 bsd.port.mk
--- bsd.port.mk 1999/01/26 03:58:58 1.303
+++ bsd.port.mk 1999/02/04 02:57:33
@@ -635,6 +635,10 @@
FETCH_CMD?= /usr/bin/ftp
.endif
+.if defined(FTP_PASSIVE_MODE) && ${FETCH_CMD} == "/usr/bin/fetch"
+FETCH_BEFORE_ARGS+= -P
+.endif
+
TOUCH?= /usr/bin/touch
TOUCH_FLAGS?= -f
> It is not clear from your paragraph what *it* is.
"It" is the variable FTP_PASSIVE_MODE, no more no less. :)
> Well, I just added
>
> :setenv=FOO=foo,BAR=bar:
>
> to my /etc/login.conf and this is what I get:
Well bugger! It works for me too now! Ehmmm. I guess I should have
tried it lately. :-) All I can say to that is that I tried this back
in 2.2.7 days and it didn't behave as expected, but in 4.0, at least,
it certainly does. Well nifty, I'm sorry to unfairly impugn the honor
of this code then. I could have sworn I hadn't see any commits to the
login class code lately. Hmmmmm!
- Jordan
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?16187.918097419>