Date: Mon, 20 May 2019 12:31:52 -0700 From: Conrad Meyer <cem@freebsd.org> To: Peter Jeremy <peter@rulingia.com> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r347984 - in head/sys: amd64/vmm/io arm/allwinner arm/allwinner/a10 arm/allwinner/clkng arm/arm arm/broadcom/bcm2835 arm/freescale/imx arm/mv arm/mv/armada arm/nvidia arm/nvidia/tegra12... Message-ID: <CAG6CVpWOdaJjzuddNwN7RKqJKuTFn0zsBEif%2B8SpTQv6u_9CMQ@mail.gmail.com> In-Reply-To: <20190520192047.GA3524@server.rulingia.com> References: <201905200038.x4K0cNoZ019920@repo.freebsd.org> <20190520192047.GA3524@server.rulingia.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Peter, Thanks for reporting this. I ran a full tinderbox on this change (many many tinderboxes) and am not sure how I missed this. I have to run to an appointment now, but will fix these in a couple hours if no one else beats me to it. The fix is straightforward =E2=80=94 include <sys/eventhandler.h>. Best, Conrad On Mon, May 20, 2019 at 12:21 PM Peter Jeremy <peter@rulingia.com> wrote: > > On 2019-May-20 00:38:23 +0000, Conrad Meyer <cem@FreeBSD.org> wrote: > >Author: cem > >Date: Mon May 20 00:38:23 2019 > >New Revision: 347984 > >URL: https://svnweb.freebsd.org/changeset/base/347984 > > > >Log: > > Extract eventfilter declarations to sys/_eventfilter.h > ... > > No functional change (intended). Of course, any out of tree modules t= hat > > relied on header pollution for sys/eventhandler.h, sys/lock.h, or > > sys/mutex.h inclusion need to be fixed. __FreeBSD_version has been bu= mped. > > This seems to have broken at least netmap and netdump for me: > /usr/src/sys/dev/netmap/netmap_freebsd.c:191:3: error: implicit declarati= on of function 'EVENTHANDLER_REGISTER' is invalid in C99 [-Werror,-Wimplici= t-function-declaration] > EVENTHANDLER_REGISTER(ifnet_arrival_event, > ^ > ... > /usr/src/sys/netinet/netdump/netdump_client.c:1458:22: error: implicit de= claration of function 'EVENTHANDLER_REGISTER' is invalid in C99 [-Werror,-W= implicit-function-declaration] > nd_detach_cookie =3D EVENTHANDLER_REGISTER(ifnet_departur= e_event, > ^ > > -- > Peter Jeremy
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpWOdaJjzuddNwN7RKqJKuTFn0zsBEif%2B8SpTQv6u_9CMQ>