Date: Thu, 25 Jan 2024 21:10:34 -0500 From: "Jason E. Hale" <jhale@freebsd.org> To: Kevin Bowling <kbowling@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 824cdca032f1 - main - audio/strawberry: Add gstreamer plugins Message-ID: <CAJE75NFQmPHf4-U-G70v1zYJagvrRk5eydmGRDS-K=SyzO_bmw@mail.gmail.com> In-Reply-To: <202401260202.40Q22Lg7066965@gitrepo.freebsd.org> References: <202401260202.40Q22Lg7066965@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 25, 2024 at 9:02=E2=80=AFPM Kevin Bowling <kbowling@freebsd.org= > wrote: > > The branch main has been updated by kbowling: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3D824cdca032f1fc8a7f02ddc8= 108a1340c7772af9 > > commit 824cdca032f1fc8a7f02ddc8108a1340c7772af9 > Author: Kevin Bowling <kbowling@FreeBSD.org> > AuthorDate: 2024-01-26 02:00:06 +0000 > Commit: Kevin Bowling <kbowling@FreeBSD.org> > CommitDate: 2024-01-26 02:00:06 +0000 > > audio/strawberry: Add gstreamer plugins > > Without these, the software is not useful and requires extra work. > There are probably some better tradeoffs, but ship the default set fr= om > the older Clementine port until proven otherwise. > > PR: 276488 > Approved by: maintainer > --- > audio/strawberry/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/audio/strawberry/Makefile b/audio/strawberry/Makefile > index fbdc4b4c3e7c..3ebea3e26936 100644 > --- a/audio/strawberry/Makefile > +++ b/audio/strawberry/Makefile > @@ -69,6 +69,7 @@ EBUR128_IMPLIES=3D GSTREAMER > > GSTREAMER_USES=3D gstreamer > GSTREAMER_CMAKE_BOOL=3D ENABLE_GSTREAMER > +GSTREAMER_USE=3D GSTREAMER=3Dcdparanoia,chromaprint,faac,faad,fl= ac,lame,mpg123,neon,opus,shout2,soup,taglib,twolame,vorbis > > ICONV_USES=3D iconv:translit > I actually did not approve this and even mentioned in the PR that many of these plugins are superfluous and that the cdparanoia plugin is only useful for the CDIO option. - Jason
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJE75NFQmPHf4-U-G70v1zYJagvrRk5eydmGRDS-K=SyzO_bmw>