Date: Mon, 10 Aug 2015 20:00:57 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Mark Johnston <markj@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r278934 - in head: cddl/contrib/opensolaris/lib/libdtrace/common share/mk Message-ID: <a8tz-c9ba-wny@FreeBSD.org> In-Reply-To: <201502180354.t1I3stA4009326@svn.freebsd.org> (Mark Johnston's message of "Wed, 18 Feb 2015 03:54:55 %2B0000 (UTC)") References: <201502180354.t1I3stA4009326@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Mark Johnston <markj@FreeBSD.org> writes: > Author: markj > Date: Wed Feb 18 03:54:54 2015 > New Revision: 278934 > URL: https://svnweb.freebsd.org/changeset/base/278934 > > Log: > Remove drti.o's dependency on libelf. This makes it possible to add DTrace > probes to userland programs and libraries without also needing to link > libelf. > > dtrace -G places the __SUNW_dof symbol at the beginning of the DOF (DTrace > probe and provider metdata) section in the generated object file; drti.o > now just uses this symbol to locate the section. A complication occurs > when multiple dtrace-generated object files are linked together, since the > __SUNW_dof symbol defined in each file is global. This is handled by > using objcopy(1) to convert __SUNW_dof to a local symbol once drti.o has > been linked with the generated object file. Upstream, this is done using a > linker feature not present in GNU ld. > > Differential Revision: https://reviews.freebsd.org/D1757 > Reviewed by: rpaulo > MFC after: 1 month > Relnotes: yes Any reason this wasn't MFC'd yet? It would serve as incentive to *not* add FreeBSD-specific conditionals for building dtrace probes in various upstream projects. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQF8BAEBCgBmBQJVyObZXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3b04cH/jc3L7hpUyLIHzJbJsr2O0dT BMkxB+APNPSQ1WX+g71mwDWXulQrWRoh9NRkfeY+A+PBBeNPi/gi2I4eYi5jp8A3 2ftQzSdLLniZxetVaCQvBrmo2t+7dzkkVYuG43QALFepUUSzZvl/sBG5wMBJ7wWr uejXE47qzOE6wifX91Tbp3d1cevR2yUdwBefLoPZcrpYPbwXEud+zzMBfirt4fmd pvDgunmkx6/7E1JnIb6aYX/OmbajBN2JUjbxQTE1Ng3aBBtP3vgUt0TmGTqQzHVU dl7QzZjLHWQuq2xrvKCRQxXSQjovLWCKbZSjx3tfLUj24sDwj8ivK+zeRBAJ8SY= =W9xz -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a8tz-c9ba-wny>