Date: Tue, 22 Jul 2003 16:07:01 -0400 From: Thomas Dickey <dickey@radix.net> To: "Jacques A. Vidrine" <nectar@freebsd.org> Cc: Kris Kennaway <kris@obsecurity.org> Subject: Re: Fixing gcc 3.3 compile failures -- fix for net/netsaint-plugins Message-ID: <20030722200700.GA2013@saltmine.radix.net> In-Reply-To: <20030722195637.GC10922@madman.celabo.org> References: <20030718025200.GA36893@rot13.obsecurity.org> <20030722122608.GC552@zi025.glhnet.mhn.de> <20030722195637.GC10922@madman.celabo.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 22, 2003 at 02:56:37PM -0500, Jacques A. Vidrine wrote:
> On Tue, Jul 22, 2003 at 02:26:08PM +0200, Simon Barner wrote:
>
> > --- plugins/check_by_ssh.c.orig Mon Apr 23 09:43:11 2001
> > +++ plugins/check_by_ssh.c Tue Jul 22 05:05:52 2003
> > @@ -191,7 +191,7 @@
> > if (commands>1)
> > remotecmd=strscat(remotecmd,";echo STATUS CODE: $?;");
> >
> > - if (strlen (remotecmd) <= 1)
> > + if (remotecmd==NULL)
> > usage ("No remotecmd\n");
> >
> > comm = ssprintf(comm,"%s %s '%s'",comm,hostname,remotecmd);
>
> This looks like more than a fix for a `compile failure'. The
> replacement code has different semantics than the new code.
> What is the `compile failure' that was being fixed here?
perhaps the compiler was pointing out that remotecmd may not be initialized.
(I don't see enough context to be sure ;-)
--
Thomas E. Dickey <dickey@radix.net> <dickey@herndon4.his.com>
http://dickey.his.com
ftp://dickey.his.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030722200700.GA2013>