Date: Fri, 6 Jul 2001 19:41:44 +0200 (CEST) From: Oliver Fromme <olli@secnetix.de> To: freebsd-bugs@FreeBSD.ORG, gnats@FreeBSD.ORG, rwatson@FreeBSD.ORG Subject: Re: kern/26740: [PATCH] jail improvement Message-ID: <200107061741.TAA66289@lurza.secnetix.de> In-Reply-To: <200104222034.f3MKYAY18904@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
rwatson@freebsd.org wrote: > Synopsis: [PATCH] jail improvement > > Responsible-Changed-From-To: freebsd-bugs->rwatson > Responsible-Changed-By: rwatson > Responsible-Changed-When: Sun Apr 22 13:28:32 PDT 2001 > Responsible-Changed-Why: > After a quick chat with Poul-Henning, we concluded I'd take ownership of > this bug report/feature request. However, we have some concerns about > the effectiveness of the patch in slightly less usual file system namespaces > (such as ones where mount within chroot occurs). > > http://www.freebsd.org/cgi/query-pr.cgi?pr=26740 [Why wasn't that comment forwarded to me by gnats via email? I just accidentally noticed it when grepping in the list archive for my old open PRs. :-( ] Anyway. It is true that the patch doesn't scale well if there are an awful lot of mounts inside jails. There's one strcmp() per mount in that case. On the other hand, the paths of mount- points are usually not very long (on my test machine, they're all in "/jail", which doesn't seem too untypical). Also, I don't think that programs running inside jails call statfs() and getfsstat() very often. So, in conclusion, I believe that there won't be any noticable problems, except under rather unusual circumstances. I could submit a modification which enables/disables the patch according to a kernel option, or even a sysctl. Please let me know if it would have a chance getting committed in that case, otherwise I'd not bother to implement that. I'm just tired to merge my patch each time I upgrade the system. ;-) I'm sure others would find the patch useful, too. Regards Oliver -- Oliver Fromme, secnetix GmbH & Co KG, Oettingenstr. 2, 80538 München Any opinions expressed in this message may be personal to the author and may not necessarily reflect the opinions of secnetix in any way. "All that we see or seem is just a dream within a dream" (E. A. Poe) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200107061741.TAA66289>